Skip to content

Astroid 2.9.1 scoped_nodes compatibility fix #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

carlio
Copy link
Member

@carlio carlio commented Jan 2, 2022

astroid.scoped_nodes is deprecated and will be moved to astroid.nodes.scoped_nodes in astroid 3.0 - see https://github.com/PyCQA/astroid/blob/main/astroid/scoped_nodes.py#L26

However it seems like the release of 2.9.1 moved some members already, so this PR just uses the new locations.

Fixes #343

@coveralls
Copy link

coveralls commented Jan 2, 2022

Coverage Status

Coverage increased (+0.02%) to 86.31% when pulling 9811df2 on 343-astroid-2.9.1-compat into fb85b71 on master.

@carlio carlio marked this pull request as ready for review January 2, 2022 11:32
@carlio
Copy link
Member Author

carlio commented Jan 2, 2022

ping @atodorov FYI

The tests all pass so I'm happy to merge it directly, but letting you know here for visibility.

@carlio carlio force-pushed the 343-astroid-2.9.1-compat branch from e58c05d to 9811df2 Compare January 2, 2022 11:34
@carlio carlio merged commit 8bab55e into master Jan 2, 2022
@carlio carlio deleted the 343-astroid-2.9.1-compat branch January 2, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin appears to broken by astroid 2.9.1
2 participants