Skip to content

Fix FUNDING.yml #10322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2025
Merged

Fix FUNDING.yml #10322

merged 4 commits into from
Mar 30, 2025

Conversation

DanielNoord
Copy link
Collaborator

@Pierre-Sassoulas I was wondering why me and @yushao2 do not show up on the homepage of the repository.

I think this is because you can't actually have these be multi-line.
See:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository

In fact, I think for this to work we actually need to prune this list to 4 contributors 😅

Should we do so? Or should we just remove this list as it is broken and only rely on tidelift?

@DanielNoord DanielNoord added the Skip news 🔇 This change does not require a changelog entry label Mar 30, 2025
@DanielNoord
Copy link
Collaborator Author

The docs build failure seems unrelated.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix the display issue for repository sponsors by addressing the multi-line formatting in FUNDING.yml and updating the pre-commit configuration accordingly.

  • Updated the exclude configuration in pre-commit to omit FUNDING.yml from certain checks.
  • Reformatted the FUNDING.yml file from a multi-line list to a single-line list.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.pre-commit-config.yaml Updates the exclude pattern to also match .github/FUNDING.yml
.github/FUNDING.yml Converts the multi-line github funding list into a single-line format
Comments suppressed due to low confidence (1)

.github/FUNDING.yml:3

  • According to the GitHub documentation referenced in the PR description, funding lists may require being pruned to 4 contributors. Please verify if limiting the list is necessary for proper display.
github: [PCManticore, Pierre-Sassoulas, cdce8p, hippo91, AWhetter, DanielNoord, areveny, DudeNr33, jacobtylerwalls, matusvalo, yushao2]

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Mar 30, 2025
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !

Co-authored-by: Pierre Sassoulas <[email protected]>
@Pierre-Sassoulas
Copy link
Member

Could be blocked by #10320 but I changed the sphinx dependencies recently in 67b3661 so...

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (aa39560) to head (ae6b6b2).
Report is 1130 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10322      +/-   ##
==========================================
+ Coverage   95.57%   95.89%   +0.32%     
==========================================
  Files         178      175       -3     
  Lines       18764    19084     +320     
==========================================
+ Hits        17934    18301     +367     
+ Misses        830      783      -47     

see 155 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DanielNoord DanielNoord merged commit 99260c7 into pylint-dev:main Mar 30, 2025
26 of 27 checks passed
@DanielNoord DanielNoord deleted the fix-funding branch March 30, 2025 19:54
@Pierre-Sassoulas
Copy link
Member

It worked. We might want to put the 4 most active with a github sponsor profile instead but this might create churn.

@DanielNoord
Copy link
Collaborator Author

Or ping @cdce8p and @jacobtylerwalls that they should setup Sponsors so they can get some recognition for all the time they have put in :)

@Pierre-Sassoulas
Copy link
Member

By the way we have a thanksdev profile since the migration from pycqa and since 02 May 23 it has accrued $610.50. At first it felt like domain name money but it could pay for IDE or something else at this point.

@DanielNoord
Copy link
Collaborator Author

Didn't know that was a thing, but it feels like we might want to distribute that amongst prominent people within the community?

@Pierre-Sassoulas
Copy link
Member

Pytest use it for pycharm pro licence for contributor who want it and travel cost when they do a sprint in person. (I don't have a lot of other examples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants