-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix FUNDING.yml
#10322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FUNDING.yml
#10322
Conversation
40f37a4
to
c1a8193
Compare
The docs build failure seems unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to fix the display issue for repository sponsors by addressing the multi-line formatting in FUNDING.yml and updating the pre-commit configuration accordingly.
- Updated the exclude configuration in pre-commit to omit FUNDING.yml from certain checks.
- Reformatted the FUNDING.yml file from a multi-line list to a single-line list.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
.pre-commit-config.yaml | Updates the exclude pattern to also match .github/FUNDING.yml |
.github/FUNDING.yml | Converts the multi-line github funding list into a single-line format |
Comments suppressed due to low confidence (1)
.github/FUNDING.yml:3
- According to the GitHub documentation referenced in the PR description, funding lists may require being pruned to 4 contributors. Please verify if limiting the list is necessary for proper display.
github: [PCManticore, Pierre-Sassoulas, cdce8p, hippo91, AWhetter, DanielNoord, areveny, DudeNr33, jacobtylerwalls, matusvalo, yushao2]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch !
Co-authored-by: Pierre Sassoulas <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10322 +/- ##
==========================================
+ Coverage 95.57% 95.89% +0.32%
==========================================
Files 178 175 -3
Lines 18764 19084 +320
==========================================
+ Hits 17934 18301 +367
+ Misses 830 783 -47 🚀 New features to boost your workflow:
|
It worked. We might want to put the 4 most active with a github sponsor profile instead but this might create churn. |
Or ping @cdce8p and @jacobtylerwalls that they should setup Sponsors so they can get some recognition for all the time they have put in :) |
By the way we have a thanksdev profile since the migration from pycqa and since 02 May 23 it has accrued $610.50. At first it felt like domain name money but it could pay for IDE or something else at this point. |
Didn't know that was a thing, but it feels like we might want to distribute that amongst prominent people within the community? |
Pytest use it for pycharm pro licence for contributor who want it and travel cost when they do a sprint in person. (I don't have a lot of other examples) |
@Pierre-Sassoulas I was wondering why me and @yushao2 do not show up on the homepage of the repository.
I think this is because you can't actually have these be multi-line.
See:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository
In fact, I think for this to work we actually need to prune this list to 4 contributors 😅
Should we do so? Or should we just remove this list as it is broken and only rely on tidelift?