-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Improve handling of aggregations for comprehensions in Pyreverse #10344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
β¦e inference in comprehensions
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #10344 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 176 176
Lines 19108 19122 +14
=======================================
+ Hits 18325 18339 +14
Misses 783 783
π New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request, I like this a lot especially the terse and fully covering test for it. Do you mind adding a changelog please ? (In doc/whatsnew/fragment, or you can use tbump and the contributor doc).
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 77b6fdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice fix/improvement! π
Type of Changes
Description
Enhanced the
AggregationsHandler
class to support detecting comprehensions (list
,dict
,set
,generator
) in Pyreverse aggregation logic.Closes #10236