Skip to content

Improve handling of aggregations for comprehensions in Pyreverse #10344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 19, 2025

Conversation

Julfried
Copy link
Contributor

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Enhanced the AggregationsHandler class to support detecting comprehensions (list, dict, set, generator) in Pyreverse aggregation logic.

Closes #10236

@Julfried Julfried requested a review from DudeNr33 as a code owner April 15, 2025 21:42
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.90%. Comparing base (6faf5b4) to head (77b6fdf).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10344   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files         176      176           
  Lines       19108    19122   +14     
=======================================
+ Hits        18325    18339   +14     
  Misses        783      783           
Files with missing lines Coverage Ξ”
pylint/pyreverse/inspector.py 81.22% <100.00%> (+1.32%) ⬆️

... and 1 file with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment has been minimized.

@Pierre-Sassoulas Pierre-Sassoulas added Enhancement ✨ Improvement to a component pyreverse Related to pyreverse component labels Apr 16, 2025
@Pierre-Sassoulas Pierre-Sassoulas added this to the 4.0.0 milestone Apr 16, 2025
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request, I like this a lot especially the terse and fully covering test for it. Do you mind adding a changelog please ? (In doc/whatsnew/fragment, or you can use tbump and the contributor doc).

Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 77b6fdf

Copy link
Collaborator

@DudeNr33 DudeNr33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice fix/improvement! πŸ‘

@DudeNr33 DudeNr33 merged commit 7d6f3f2 into pylint-dev:main Apr 19, 2025
45 checks passed
@Julfried Julfried deleted the improve-comp branch April 21, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component pyreverse Related to pyreverse component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composition not detected correctly in list comprehension
3 participants