Skip to content

no-value-for-parameter variadic detection has improved for assign statements #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2020

Conversation

PCManticore
Copy link
Contributor

Description

The problem was caused by the exemption of variadics for no-value-for-parameter not being smart enough when deciding if a statement should be included or not. Previously only return statements or expressions were taking in consideration, but right hand side of assignments should also be exempted when dealing with variadics.

Type of Changes

Type
🐛 Bug fix

Related Issue

Close #3563

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 90.387% when pulling ac8a5da on no-value-for-param-false-positive into 1654e49 on 2.5.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 90.387% when pulling ac8a5da on no-value-for-param-false-positive into 1654e49 on 2.5.

@coveralls
Copy link

coveralls commented May 2, 2020

Coverage Status

Coverage remained the same at 90.431% when pulling ac8a5da on no-value-for-param-false-positive into 1654e49 on 2.5.

@PCManticore PCManticore merged commit 56495fd into 2.5 May 2, 2020
@PCManticore PCManticore deleted the no-value-for-param-false-positive branch May 2, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants