Unify, document and fix functional tests internal updating process #4004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Bug 🪲
task
Needs review 🔍
PCManticore
reviewed
Jan 1, 2021
tests/test_func.py
Outdated
| if len(sys.argv) > 1: | ||
| FILTER_RGX = sys.argv[1] | ||
| del sys.argv[1] | ||
| pytest.main(sys.argv) | ||
| if UPDATE_FILE.exists(): |
There was a problem hiding this comment.
Is the intention here to delete it only after the tests complete successfully or in all the cases, including test failures? Worth putting in a try-finally if it's the latter.
There was a problem hiding this comment.
Fixed in 98dc5ca
2 similar comments
Pierre-Sassoulas
force-pushed
the
unify-functional-test-update
branch
from
fb29593 to
98dc5ca
Compare
PCManticore
approved these changes
Jan 1, 2021
orSolocate
referenced
this pull request
in orSolocate/pylint
Feb 1, 2021
Pierre-Sassoulas
removed
the
Needs review 🔍
6 tasks
Pierre-Sassoulas
added
Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix the problem we had with the command supposed to update functional tests. It uniformize it between legacy and current functional tests, document it for legacy tests and fix it for current functional tests.
Type of Changes