Apply const-naming-style to module const annotated with Final #4280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I rebased this one and it is ready for review. |
cdce8p
commented
Apr 1, 2021
Comment on lines
+12
to
+13
| * Apply ``const-naming-style`` to module constants annotated with | ||
| ``typing.Final`` |
There was a problem hiding this comment.
Should it be a 2.8 or a 2.7.5 feature?
There was a problem hiding this comment.
Depends on the end result of the discussion in #4263 :)
Pierre-Sassoulas
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
This depends on #4279 and should be rebased once it's merged.
Apply the
const-naming-styleto module constants if they are annotated with withtyping.Final.Type of Changes