Add regression tests for inference bug repros #4387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nelfin
added a commit
to nelfin/astroid
that referenced
this pull request
Apr 22, 2021
Ref pylint-dev/pylint#4083. Ref pylint-dev/pylint#4387. When used in a nodes.Subscript, an existing inference_tip was set for Name nodes matching called type. However, when this name was redefined this led to false-positive typecheck errors in pylint such as invalid-sequence-index (see pylint-dev/pylint#4083 and pylint-dev/pylint#4387)
2 tasks
nelfin
added a commit
to nelfin/astroid
that referenced
this pull request
Apr 22, 2021
Ref pylint-dev/pylint#4083. Ref pylint-dev/pylint#4387. When used in a nodes.Subscript, an existing inference_tip was set for Name nodes matching called type. However, when this name was redefined this led to false-positive typecheck errors in pylint such as invalid-sequence-index (see pylint-dev/pylint#4083 and pylint-dev/pylint#4387)
nelfin
added a commit
to nelfin/astroid
that referenced
this pull request
May 2, 2021
Ref pylint-dev/pylint#4083. Ref pylint-dev/pylint#4387. When used in a nodes.Subscript, an existing inference_tip was set for Name nodes matching called type. However, when this name was redefined this led to false-positive typecheck errors in pylint such as invalid-sequence-index due to the argument being inferred as builtins.type and inference_tip preventing any further inference.
Pierre-Sassoulas
pushed a commit
to pylint-dev/astroid
that referenced
this pull request
May 2, 2021
Ref pylint-dev/pylint#4083. Ref pylint-dev/pylint#4387. When used in a nodes.Subscript, an existing inference_tip was set for Name nodes matching called type. However, when this name was redefined this led to false-positive typecheck errors in pylint such as invalid-sequence-index due to the argument being inferred as builtins.type and inference_tip preventing any further inference.
Pierre-Sassoulas
force-pushed
the
fix/2.8.x-regression-tests
branch
from
a406b17 to
76dc276
Compare
|
I rebased on the latest main and opened #6521 to merge the commit that is passing right now. It look like the other two are still an issue. |
Pierre-Sassoulas
force-pushed
the
fix/2.8.x-regression-tests
branch
from
76dc276 to
750a4f8
Compare
|
@Pierre-Sassoulas At what point do we close these stale old PRs? It might make it easier to do management of the project if we keep only active PRs open? |
DanielNoord
added
Needs take over 🛎️
|
True, we can take over even if the PR is closed. I often don't dare to close to not offend the implementer. (My own MR often go stale) |
|
I have added "Needs take over" to most stale PRs. I think we can craft a friendly message explaining we're doing some clean up and then close most of them :) |
Pierre-Sassoulas
force-pushed
the
fix/2.8.x-regression-tests
branch
from
750a4f8 to
6184c76
Compare
Pierre-Sassoulas
added
Maintenance
Pierre-Sassoulas
approved these changes
Mar 30, 2025
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
Type of Changes
Related Issue