Add sys.version_info guard to import-error #4468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggested by @KapJI here: home-assistant/core#50444 (comment)
Don't emit an
import-error
if import is guarded behindif sys.version_info
. Since pylint can only check the python version it's executed with, this often results in a false-positive.The current suggestion doesn't account for imports that are truly missing, since the
if
statement can't (yet) be easily inferred. Implementing this would be possible, but probably not worth it.Examples
If tested with
pylint <= 3.8
, this would have resulted in animport-error
without this change.Type of Changes