-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Create common Printer
base class for pyreverse
and improve typing.
#4731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Pierre-Sassoulas
merged 8 commits into
pylint-dev:main
from
DudeNr33:pyreverse-refactoring-printer
Aug 3, 2021
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
649b6e7
Create common ``Printer`` base class for Pyreverse, and improve typing.
DudeNr33 30a1c25
Implement review suggestion - replace ``get_file_extension`` with ``p…
DudeNr33 f3c3bcb
Merge branch 'main' into pyreverse-refactoring-printer
DudeNr33 d223220
Create separate file for ``Printer`` base class and ``DotPrinter``, a…
DudeNr33 7fff703
Use ``abc.ABC`` as metaclass for ``Printer`` instead of raising ``Not…
DudeNr33 1672353
Move some methods back to original position to make diffing easier
DudeNr33 e299c64
Implement suggested changes from review.
DudeNr33 5f624b7
Rename ``vcgutils.py`` to ``vcg_printer.py``
DudeNr33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the type hints revealed that it was necessary to distinguish between a
PackageEntity
and aClassEntity
, because theClassEntity
has additional attributes that were dynamically added in the previous code, which confusedmypy
.