Update toml dependency to >=0.9.2

[jeroenseegers]

Type of Changes

	Type
✓	🐛 Bug fix

Description

Fix the minimum version of the toml dependency as described in #5066.

Closes #5066

[coveralls]

Pull Request Test Coverage Report for Build 1266038107

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 93.091%

---

Totals
Change from base Build 1265024268:	0.0%
Covered Lines:	13352
Relevant Lines:	14343

---

💛 - Coveralls

[Pierre-Sassoulas]

I came across this due to a shared dependency on toml between two packages, of which one has toml<0.10,>=0.9 causing toml==0.9.6 to be installed.

Wouldn't that make pylint incompatible with this package ? Maybe the fix is to handle both import by adding an import guard and keep the compatibility with toml > 0.7 ?

[jeroenseegers]

I came across this due to a shared dependency on toml between two packages, of which one has toml<0.10,>=0.9 causing toml==0.9.6 to be installed.

Wouldn't that make pylint incompatible with this package ? Maybe the fix is to handle both import by adding an import guard and keep the compatibility with toml > 0.7 ?

I'm not sure if that's very relevant in this case. It's a tag of a package > 2 years old by now (0), and this particular bug has been present for ~7 months in pylint without any previous mention of it before this issue and PR.

[cdce8p]

From what I can tell, we should be able to import TomlDecodeError from toml directly even in 0.10.0. Just need to update the code. With that we shouldn't need to update the dependency.
https://github.com/PyCQA/pylint/blob/09a0b50bfeb473625f8ad586f72fd35d790de6ac/pylint/config/find_default_config_files.py#L8

toml/__init__.py - 0.10.0

[jeroenseegers]

From what I can tell, we should be able to import TomlDecodeError from toml directly even in 0.10.0. Just need to update the code. With that we shouldn't need to update the dependency.

https://github.com/PyCQA/pylint/blob/09a0b50bfeb473625f8ad586f72fd35d790de6ac/pylint/config/find_default_config_files.py#L8

toml/__init__.py - 0.10.0

The issue is that this import is only available from 0.10.0 onwards, not in earlier versions.

From 0.9.2 it's available as from toml import TomlDecodeError: https://github.com/uiri/toml/blob/0.9.2/toml.py

Before that, TomlDecodeError does not exist at all.

[cdce8p]

The issue is that this import is only available from 0.10.0 onwards, not in earlier versions.

From 0.9.2 it's available as from toml import TomlDecodeError`: https://github.com/uiri/toml/blob/0.9.2/toml.py

Before that, TomlDecodeError does not exist at all.

👍🏻 In that case we should probably require 0.9.2.

[jeroenseegers]

👍🏻 In that case we should probably require 0.9.2.

Shall I then make it toml>=0.9.2,<0.10 and change
https://github.com/PyCQA/pylint/blob/09a0b50bfeb473625f8ad586f72fd35d790de6ac/pylint/config/find_default_config_files.py#L8
to

from toml import TomlDecodeError

?

[cdce8p]

LGTM! Thanks @jeroenseegers 🐬

[Pierre-Sassoulas]

Thank you, great catch !