Improve node info for invalid-name #5094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment
invalid-name
for a function argument is emitted on thefunction
node. That does work, however it limits wherepylint: disable
can be set. Consider the following example:Only
invalidName
is wrong. With this change it's now possible to addpylint: disable
directly behind it instead of afterdef func
.This appears to be fully backwards compatible. I.e. both with disable
invalid-name
: