Skip to content

Fix py-version usage in typing extension tests #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2021
Merged

Fix py-version usage in typing extension tests #5161

merged 1 commit into from
Oct 15, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 15, 2021

Description

  • Move py-version from [typing] to [master]
  • Make sure py-version >= min_pyver

@cdce8p cdce8p added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Oct 15, 2021
@cdce8p cdce8p added this to the 2.12.0 milestone Oct 15, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1346005344

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.217%
Totals Coverage Status
Change from base Build 1345786261: 0.0%
Covered Lines: 13592
Relevant Lines: 14581
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why the pyversion is changed from py37 to py38 sometime? I don't understand.

@cdce8p
Copy link
Member Author

cdce8p commented Oct 15, 2021

Could you explain why the pyversion is changed from py37 to py38 sometime? I don't understand.

Same reason as with the tests for the alternative union syntax. These files also import TypedDict. At the moment it doesn't matter. That might change though: #5134 (comment)

@cdce8p cdce8p merged commit ab775f6 into pylint-dev:main Oct 15, 2021
@cdce8p cdce8p deleted the fix_py-version-typing branch October 15, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @coveralls @Pierre-Sassoulas