-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Clarify syntax in pylint.lint example #5260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the better example ! I think your commit message so idiots don't me get stuck.
could be reordered to so it's harder to get stuck.
More seriously could you add yourself to the contributors, please ? :)
I'll keep the stackoverflow question in mind, I did not manage to make it work myself yet, which is a clue that new documentation will be required.
Pull Request Test Coverage Report for Build 1431158554
💛 - Coveralls |
This makes the call non-trivial and demonstrates the syntax more fully.
Done. I assumed it's not worth making an entry in the file for such a small contribution, but if it's policy then sure. |
I have investigated this a bit more. Without changes to |
That was my conclusion too. I had the impression it was a problem with kwargs not being taken into account, but I did not go in depth. Do you want to create the issue @DanielNoord ?
I pretty much agree, I think we need |
Opened an issue to track the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm merging as this is still clearer than what we had before. Follow up to be able to recover the output in a stream is #5295.
This makes the call in the documentation non-trivial, so that idiots like me don't get stuck.
If someone could show how to get the output of the command (as asked here), that would also be very helpful to add.
doc/whatsnew/<current release.rst>
.