Make self-cls-assignment check tuple assignment
#5268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
the
False Negative 🦋
Pull Request Test Coverage Report for Build 1431817024
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Nov 6, 2021
cdce8p
reviewed
Nov 7, 2021
| child | ||
| for child in scope.body | ||
| if isinstance(child, nodes.Nonlocal) and assign_names & set(child.names) | ||
| child for child in scope.body if isinstance(child, nodes.Nonlocal) |
There was a problem hiding this comment.
It seems like we also need to do some more work on node.scope().
Cannot access member "body" for type "LocalsDictNodeNG"
Member "body" is unknown
Co-authored-by: Marc Mueller <[email protected]>
cdce8p
approved these changes
Nov 7, 2021
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Nov 7, 2021
Co-authored-by: Marc Mueller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/whatsnew/<current release.rst>.Type of Changes
Description
Continuation of #5254
Basically we only checked single assignments and will now also check tuple assignments.
Furthermore, I have removed some redundant code.