Skip to content

Refactor before fixing the TOML crashes #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 8, 2021
Merged

Refactor before fixing the TOML crashes #5276

merged 4 commits into from
Nov 8, 2021

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✓ 🔨 Refactoring

Description

Some small refactor prior to #4720 so it's easier to see what really changed in the final PR.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Nov 8, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.0 milestone Nov 8, 2021
@coveralls
Copy link

coveralls commented Nov 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1433989333

  • 19 of 21 (90.48%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 93.347%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/config/option_manager_mixin.py 19 21 90.48%
Totals Coverage Status
Change from base Build 1433801978: 0.002%
Covered Lines: 13778
Relevant Lines: 14760
💛 - Coveralls

@Pierre-Sassoulas
Rename test_can_read_env_variable so it has 'toml' in it
6662b3d 
It permits to launch the toml test easily with pytest -k toml
@Pierre-Sassoulas Pierre-Sassoulas merged commit 35cdd07 into main Nov 8, 2021
@Pierre-Sassoulas Pierre-Sassoulas deleted the toml-fix-pre-refactor branch November 8, 2021 09:14
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Pierre-Sassoulas @coveralls @DanielNoord