Move tests from TestParamDocChecker to functional tests

[DanielNoord]

• Add yourself to CONTRIBUTORS if you are a new contributor.
• Write a good description on what the PR does.

Type of Changes

	Type
✓	🔨 Refactoring

Description

Last move for TestParamDocChecker 😄

[coveralls]

Pull Request Test Coverage Report for Build 1572457590

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 11 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.07%) to 93.641%

---

Files with Coverage Reduction	New Missed Lines	%
pylint/testutils/checker_test_case.py	1	96.77%
pylint/testutils/decorator.py	10	63.64%

Totals
Change from base Build 1571889854:	-0.07%
Covered Lines:	14181
Relevant Lines:	15144

---

💛 - Coveralls

[DanielNoord]

@Pierre-Sassoulas Do you want me to remove these unused testutils? Or do we want to keep them for future uses?

[Pierre-Sassoulas]

👍

[Pierre-Sassoulas]

Do you want me to remove these unused testutils?

Let's keep them so it's not a breaking change for plugin developer.

[DanielNoord]

Let's keep them so it's not a breaking change for plugin developer.

Shall I add a DeprecationWarning? set_config_directly was added in 2.12 (perhaps 2.11) by me as a hacky solution to an issue with multiple checkers using the same config names. If you're using it you should probably redesign your checker 😄

[Pierre-Sassoulas]

Sorry I missed that we just added them in 2.12.2 I think we could remove, I doubt anyone jumped on it.

[DanielNoord]

Sorry I missed that we just added them in 2.12.2 I think we could remove, I doubt anyone jumped on it.

It was 2.12, see #5195

Still okay with removing that decorator?

[Pierre-Sassoulas]

Do you want to revert 5195 ? I hope in the future there won't be the same argument in multiple checker in the configuration so removing it would not be a problem anymore. Meanwhile using functional test all the time has a lot of advantages.

[DanielNoord]

I don't think reverting makes sense as #5195 actually built upon other changes to these decorators.

For now I would propose to deprecate set_config_directly in 2.13 and remove it in 2.14:
If plugin developers are actively developing plugins that they jumped on this after 2.12 I think they should also notice this deprecation. Normally we should obviously remove it in 3.0 but since this is actually allowing badly designed checkers to be tested in a hacky way I don't think we should wait for it.
If you agree I'll merge this and then do a follow-up with the deprecation.

[Pierre-Sassoulas]

The minor version deprecation makes a lot of sense, let's do that 👍