Fix #5557: Don't emit comparison-with-callable if the callable raises
#5563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
typing
False Positive 🦟
Pull Request Test Coverage Report for Build 1606974330
💛 - Coveralls |
|
The issue with the pipeline was due to #5561, it's reverted now, you should rebase to fix the primers :) |
…lable raises Typing constants such as `typing.Any` raise when called.
jacobtylerwalls
force-pushed
the
raise-when-called
branch
from
14d15dd to
a35e7cf
Compare
Co-authored-by: Pierre Sassoulas <[email protected]>
DanielNoord
requested changes
Dec 21, 2021
tests/functional/c/comparison_with_callable_typing_constants.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniël van Noord <[email protected]>
Co-authored-by: Daniël van Noord <[email protected]>
DanielNoord
approved these changes
Dec 21, 2021
jacobtylerwalls
commented
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Typing constants such as
typing.Anyraise when called, which means they should not emitcomparison-with-callable.This PR skips emitting that message when a callable raises in its body (or if it's a typing constant, since some typing constants only raise via their decorator, not via their body).
Closes #5557