Fix #5586: False positive for used-before-assignment with homonyms in filtered comprehensions and except blocks
#5666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… homonyms in filtered comprehensions and except blocks
DanielNoord
approved these changes
Jan 11, 2022
|
Thanks for picking this up immediately @jacobtylerwalls! Not 100% about the place as well, but since this is what was making the method exit early this seem to be okay! |
DanielNoord
added
the
False Positive 🦟
Pull Request Test Coverage Report for Build 1688103945
💛 - Coveralls |
Co-authored-by: Pierre Sassoulas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #5586
With a small adjustment, @DanielNoord's suggestion in #5586 (comment) passes the suite, so I just opened a PR. I'm not certain this is the best way to do this, but I tried an alternative diff in
get_next_to_consume(), and it turned out to be more questionable.