Avoid using get on a defaultdict #5766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1789962783
💛 - Coveralls |
DanielNoord
approved these changes
Feb 3, 2022
Pierre-Sassoulas
requested changes
Feb 3, 2022
| @@ -1659,7 +1659,7 @@ def _get_messages_to_set( | |||
| else: | |||
| category_id_formatted = category_id | |||
| if category_id_formatted is not None: | |||
| for _msgid in self.msgs_store._msgs_by_category.get(category_id_formatted): | |||
| for _msgid in self.msgs_store._msgs_by_category[category_id_formatted]: | |||
There was a problem hiding this comment.
Suggested change
| for _msgid in self.msgs_store._msgs_by_category[category_id_formatted]: | |
| for _msgid in self.msgs_store._msgs_by_category.get(category_id_formatted, []): |
|
It won't, as it's a defaultdict. If the key doesn't exist it'll make one by the default factory ( |
Pierre-Sassoulas
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
I was poking around Pylint internals, trying to add new issue categories to the codebase, and stumbled upon this bug.
Since
MessageDefinitionStore._msgs_by_categoryis adefaultdict(list), using.get()here can break the code on bad input, because it will returnNone, which is not iterable.