Skip to content

Use the argparse config handler in class_checker.py #6109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2022
Merged

Use the argparse config handler in class_checker.py #6109

merged 4 commits into from
Apr 2, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Apr 1, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 1, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2079920722

  • 14 of 15 (93.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 94.269%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/config/argument.py 12 13 92.31%
Totals Coverage Status
Change from base Build 2079916425: -0.003%
Covered Lines: 15512
Relevant Lines: 16455
💛 - Coveralls

@DanielNoord DanielNoord mentioned this pull request Apr 1, 2022
Merged
2 tasks
DanielNoord
DanielNoord commented Apr 1, 2022
View reviewed changes
pylint/config/argument.py
return True
if value in NO_VALUES:
return False
raise argparse.ArgumentError(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be covered as soon as we flip the switch. optparse now raises a warning here.

@DanielNoord
Copy link
Collaborator Author

I'm merging this as a PR which had the same changes (#6110) was already approved.

@DanielNoord DanielNoord merged commit b7a9499 into pylint-dev:main Apr 2, 2022
@DanielNoord DanielNoord deleted the argparse-class_checker branch April 2, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Awaiting requested review from Pierre-Sassoulas

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielNoord @coveralls