Bump py-version and add python-typing-update to CI #6326
Conversation
DanielNoord
added
the
Maintenance
Pull Request Test Coverage Report for Build 2169749732
💛 - Coveralls |
.pre-commit-config.yaml
Outdated
| - repo: https://github.com/cdce8p/python-typing-update | ||
| rev: v0.4.1 | ||
| hooks: | ||
| - id: python-typing-update | ||
| stages: [manual] | ||
| additional_dependencies: | ||
| - "black==22.3.0" | ||
| args: | ||
| - --py37-plus | ||
| - --force | ||
| - --keep-updates | ||
| - --black | ||
| files: ^(pylint)/.+\.py$ |
There was a problem hiding this comment.
I don't think we should add this. The existing pylint checks are much better.
.github/workflows/checks.yaml
Outdated
| @@ -121,6 +121,7 @@ jobs: | |||
| . venv/bin/activate | |||
| pip install -e . | |||
| pre-commit run pylint --all-files | |||
| pre-commit run --hook-stage manual python-typing-update --all-files | |||
.pre-commit-config.yaml
Outdated
| - repo: https://github.com/cdce8p/python-typing-update | ||
| rev: v0.4.1 | ||
| hooks: | ||
| - id: python-typing-update | ||
| stages: [manual] | ||
| additional_dependencies: | ||
| - "black==22.3.0" | ||
| args: | ||
| - --py37-plus | ||
| - --force | ||
| - --keep-updates | ||
| - --black | ||
| files: ^(pylint)/.+\.py$ |
There was a problem hiding this comment.
I agree with what Marc said earlier, that pylint's typing extension is vastly more efficient. I would rather add the typing extension to our pylintrc. I think we should only handle the bump of the py-version in this MR and discuss the pre-commit hook in another one.
There was a problem hiding this comment.
I would rather add the typing extension to our pylintrc.
It's already enabled. We just need to update py-version.
I think we should only handle the bump of the py-version in this MR and discuss the pre-commit hook in another one.
AFAICT the typing changes here are from #6325.
With the typing extension, we don't need to add any other pre-commit hook 😄
|
Changed to only the |
Type of Changes
Description
We can tick off two things in #4683 😄