-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add related and details.rst to 'redundant-unittest-assert' style message's doc #6483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Pierre-Sassoulas
merged 7 commits into
pylint-dev:main
from
Pierre-Sassoulas:follow-up-to-6475
May 1, 2022
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b170853
Add related and details.rst to 'redundant-unittest-assert' doc
Pierre-Sassoulas 54e8a90
Take review into account
Pierre-Sassoulas e73767a
oups
Pierre-Sassoulas 9d90186
Apply suggestions from code review
Pierre-Sassoulas 9234cdb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a82ce25
Add a details.rst for assert-on-tuple
Pierre-Sassoulas 8263e52
Update doc/data/messages/a/assert-on-tuple/details.rst
Pierre-Sassoulas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
def test(): | ||
assert "There is an AssertionError" # [assert-on-string-literal] | ||
def test_division(): | ||
a = 9 / 3 | ||
assert "No ZeroDivisionError were raised" # [assert-on-string-literal] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
Directly asserting a string literal will always pass. | ||
Directly asserting a string literal will always pass. The solution is to | ||
test something that could fail, or not assert at all. | ||
|
||
This message is similar to ``redundant-unittest-assert``. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
def test(): | ||
result = "result" | ||
expected = "expected" | ||
assert result == expected | ||
def test_division(): | ||
a = 9 / 3 | ||
assert a == 3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
- `Tests without assertion <https://stackoverflow.com/a/137418/2519059>`_ | ||
- `Testing that there is no error raised <https://stackoverflow.com/questions/20274987>`_ | ||
- `Parametrizing conditional raising <https://docs.pytest.org/en/latest/example/parametrize.html#parametrizing-conditional-raising>`_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
Directly asserting a string literal will always pass. | ||
Directly asserting a string literal will always pass. The solution is to | ||
test something that could fail, or not assert at all. | ||
|
||
This message is similar to ``assert-on-string-literal``. | ||
Pierre-Sassoulas marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
- `Tests without assertion <https://stackoverflow.com/a/137418/2519059>`_ | ||
- `Testing that there is no error raised <https://stackoverflow.com/questions/20274987>`_ | ||
- `Parametrizing conditional raising <https://docs.pytest.org/en/latest/example/parametrize.html#parametrizing-conditional-raising>`_ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.