Allow not yet published extensions links in linkcheck
#6499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
Documentation 📗
Maintenance
Pull Request Test Coverage Report for Build 2274784795
💛 - Coveralls |
| @@ -241,3 +241,5 @@ | |||
| # Prevent label issues due to colliding section names | |||
| # through including multiple documents | |||
| autosectionlabel_prefix_document = True | |||
|
|
|||
| linkcheck_ignore = ["https://github.com/PyCQA/pylint/blob/main/pylint/extensions/.*"] | |||
There was a problem hiding this comment.
Could we check the extension on main (where the extension should be published already) but not on feature branch by creating a CI job specific for this test ?
There was a problem hiding this comment.
Yeah, but then we're likely to miss failures on the step right? I don't think these links will ever break, so it should be fine to just ignore these very specific links in normal CI runs?
There was a problem hiding this comment.
Well, 2 weeks ago we did not check ANY links, I think we'll be fine 😄
There was a problem hiding this comment.
All the choices are somewhat flawed :-)
Pierre-Sassoulas
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fixes #6470.