Skip to content

Update all TODO: 2.14 #6573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

Update all TODO: 2.14 #6573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pylint/checkers/classes/special_methods_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ def _is_iterator(node):
if isinstance(node, astroid.bases.Generator):
# Generators can be iterated.
return True
# TODO: 2.14: Should be covered by https://github.com/PyCQA/astroid/pull/1475
if isinstance(node, nodes.ComprehensionScope):
# Comprehensions can be iterated.
return True
Expand Down
1 change: 0 additions & 1 deletion pylint/checkers/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,6 @@ def _supports_protocol(
if protocol_callback(value):
return True

# TODO: 2.14: Should be covered by https://github.com/PyCQA/astroid/pull/1475
if isinstance(value, nodes.ComprehensionScope):
return True

Expand Down
2 changes: 1 addition & 1 deletion pylint/config/callback_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def __call__(
values: str | Sequence[Any] | None,
option_string: str | None = "--generate-rcfile",
) -> None:
# TODO: 2.14: Deprecate this after discussion about this removal has been completed.
# TODO: 2.15: Deprecate this after discussion about this removal has been completed.
with warnings.catch_warnings():
warnings.filterwarnings("ignore", category=DeprecationWarning)
self.run.linter.generate_config(skipsections=("Commands",))
Expand Down