Add support of sharing message in multiple checkers. Fix DeprecatedChecker example #6693

matusvalo · 2022-05-24T23:38:22Z

Type of Changes

	Type
✓	🐛 Bug fix
	✨ New feature
✓	🔨 Refactoring
✓	📜 Docs

Description

This PR move message definitions from msgs attribute of DeprecatecMixin to separate class attributes. msgs attribute cannot be used directly anyway because it mixes two different message classes: W15XX and W04XX.

Closes #6656

for more information, see https://pre-commit.ci

coveralls · 2022-05-25T00:22:25Z

Pull Request Test Coverage Report for Build 2493613951

13 of 13 (100.0%) changed or added relevant lines in 6 files are covered.
260 unchanged lines in 25 files lost coverage.
Overall coverage increased (+0.1%) to 95.543%

Files with Coverage Reduction	New Missed Lines	%
pylint/checkers/spelling.py	1	77.78%
pylint/extensions/comparetozero.py	1	97.06%
pylint/utils/docs.py	1	98.15%
pylint/checkers/base/basic_error_checker.py	2	95.45%
pylint/checkers/modified_iterating_checker.py	2	97.56%
pylint/config/arguments_manager.py	2	98.22%
pylint/checkers/base/docstring_checker.py	3	96.63%
pylint/config/find_default_config_files.py	3	89.23%
pylint/extensions/docparams.py	3	98.43%
pylint/checkers/imports.py	4	94.42%

Totals
Change from base Build 2378134557:	0.1%
Covered Lines:	16420
Relevant Lines:	17186

💛 - Coveralls

…e pylint happy

for more information, see https://pre-commit.ci

Pierre-Sassoulas

Would it be possible to add a short example in the developer guide, please ? I think this one checker is very likely to be customized. (Maybe we could provide a way to just configure what is deprecated or not in the configuration but that's probably for another MR)

matusvalo · 2022-05-25T05:38:26Z

Would it be possible to add a short example in the developer guide, please ?

I can. Should be done in this MR or should I create new one?

Moreover I think, we should include in our tests execution of the examples to avoid having them outdated and not running...

Pierre-Sassoulas · 2022-05-25T06:33:36Z

Either works :)

Related to your last point about checking the exemples of the doc we'd need some kind of structure like for bad.py / good.py, but this is a really neat idea !

DanielNoord · 2022-05-25T06:41:06Z

pylint/checkers/deprecated.py


-    msgs: dict[str, MessageDefinitionTuple] = {
+    DEPRECATED_MSGS: dict[str, MessageDefinitionTuple] = {


Shouldn't this be called:

Suggested change

DEPRECATED_MSGS: dict[str, MessageDefinitionTuple] = {

DEPRECATED_MSGS_STDLIB: dict[str, MessageDefinitionTuple] = {

This is a question how DeprecatedMixin is supposed to be used:

should external users reuse DeprecatedMixin?

if yes should they use MSGS which are used also in STDLIB checker (W15XX) and import checker (W0402)? If W15XX and W0402 are reused also for external users the renaming is confusing then because it is not connected to STDLIB only.

if no we should somehow parametrize the mixin allowing users to specify which message should be raised

if external users should not reuse DeprecatedMixin we can do the renaming.

should external users reuse DeprecatedMixin?

I'm wondering why we do not have a configuration for deprecations checks ? Isn't it possible to have user modifiable deprecated_functions, deprecated_classes list options ?

I'm wondering why we do not have a configuration for deprecations checks ? Isn't it possible to have user modifiable deprecated_functions, deprecated_classes list options ?

We can provide to the user these options. Should it go with this PR?

In any case I think some users will need subclassing DeprecatedMixin. By subclassing mixin user can check the deprecated function also based on version - e.g. django plugin can check deprecated django functions/classes based on django version. This cannot be done by simple list of functions/modules in configuration file.

We can provide to the user these options. Should it go with this PR?

Let's first handle this PR.

By subclassing mixin user can check the deprecated function also based on version - e.g. django plugin can check deprecated django functions/classes based on django version.

Ha right, it make sense.

DanielNoord · 2022-06-02T13:46:39Z

@matusvalo What about moving these messages to (for example) 49xx and special casing 49xx in the CI check to be mixed with other prefixes? Wouldn't that also solve the problem?

Edit: That also allows plugin writers to use our CI check by creating any new deprecation messages with 49xx as well.

matusvalo · 2022-06-03T07:22:16Z

What about moving these messages to (for example) 49xx and special casing 49xx in the CI check to be mixed with other prefixes? Wouldn't that also solve the problem?

@DanielNoord unfortunately I don't understand. :-( What is CI?

DanielNoord · 2022-06-03T07:24:40Z

What about moving these messages to (for example) 49xx and special casing 49xx in the CI check to be mixed with other prefixes? Wouldn't that also solve the problem?

@DanielNoord unfortunately I don't understand. :-( What is CI?

Continuous Integration. The checks we run with Github Actions.

The reason for the weird dictionary creation is because we have a check that makes sure that all messages in a checker have the same first two digits. This is what is causing issues for this Mixin. It's defining messages for different checkers that have different "prefixes" (those two first digits).
My idea is to create a prefix for the mixing (let's say 49) and then allow that prefix to be mixed with other prefixes in checkers. That would remove the need for the double dictionaries and still pass all tests.

for more information, see https://pre-commit.ci

matusvalo · 2022-06-03T21:17:31Z

My idea is to create a prefix for the mixing (let's say 49) and then allow that prefix to be mixed with other prefixes in checkers. That would remove the need for the double dictionaries and still pass all tests.

I understand now. But I have a two questions:

stdlib checker and import checker should be migrated to the new codes of mixin? If yes it will break backward compatibility (e.g. msg ID W0402 for deprecated-module will change to W49XY).
other posibility is to leave deprecated-module/W0402 in stdlib checker and create new on derecated-module2/W4902. I don't like it because it is confusing for users (why we have multiple messages for deprecated-module? Again maybe we can have 2 checks with same name with different msg ID but this will be totally confusing

Hence, for now I did most safest change:

I have added shared_messages dictionary where you have messages which are not checked by consistency check.
I have left all messages from stdlib checker/import checker in DeprecatedMixin
The change is backward compatible and user friendly. The only issue is that the Message IDs are coming from different checkers (not ideal better to have special msg IDs for the mixin), but I consider it a lesser evil comparing to previous 2 points/questions.

matusvalo · 2022-06-03T21:20:49Z

Hm CI is failing due inconsistent Messages. Now I see why we were talking about CI... :-/

DanielNoord · 2022-06-04T08:44:12Z

stdlib checker and import checker should be migrated to the new codes of mixin? If yes it will break backward compatibility (e.g. msg ID W0402 for deprecated-module will change to W49XY).

Let's do this with the old_names setup. You can look at missing-class-docstring to see how that works normally. That is a safe way to rename messages to new ids.

DanielNoord

This is exactly what I meant! Thanks @matusvalo!

Only one issue remains:
The creation of the messages documentation. As you can see from the RTD output we're not creating two pages for every message in the MixIn as they are found on two checkers. Do you think you'll be able to find a solution for this or do you need some pointers? I don't have a good idea yet, but since this is based on our own Sphinx extension it shouldn't be too hard!

pylint/checkers/base_checker.py

matusvalo · 2022-06-11T11:09:13Z

@DanielNoord @Pierre-Sassoulas please have a look to PR:

The Deprecated messages can be now shared between Checkers using shared option.
The sphinx plugin now can detect shared messages and add the links to the documentation of the messages
The deprecated example was updated and now is working

DanielNoord

Some early feedback!

Thanks for all the work you put in to this @matusvalo!

doc/exts/pylint_messages.py

DanielNoord · 2022-06-11T11:14:58Z

doc/exts/pylint_messages.py

@@ -7,7 +7,7 @@
 import os


This all seems to work.

The only thing I would add is to add all checkers that can emit a message to the page. So for these messages both stdlib and imports. But that can also be done in a follow-up.

The only thing I would add is to add all checkers that can emit a message to the page

If I understand your comment correctly, this is already implemented. See _write_single_shared_message_page and _write_single_message_page functions.

@matusvalo Did you decide to do a follow-up? If so, could you open the issue?

The only thing I would add is to add all checkers that can emit a message to the page. So for these messages both stdlib and imports. But that can also be done in a follow-up.

@DanielNoord not sure if I understand. Currently, all checkers emitting the message are showed. Currently, we don't have a Message that is used by multiple checkers, hence only one checker is showed for deprecated-* messages:

But the logic is universal, suppose we add to the Imports checker another message used by stdlib checker:

When we generate documentation with this code change, following page is showed:

pylint/checkers/deprecated.py

pylint/message/message_definition.py

Co-authored-by: Daniël van Noord <[email protected]>

Pierre-Sassoulas

LGTM, amazing work ! It will be useful to make the checker more modular. I wonder if you could create a small explanation on how to do that in the contributor doc on checkers ?

…/pylint into fix_deprecated_example

matusvalo · 2022-06-13T19:44:39Z

LGTM, amazing work ! It will be useful to make the checker more modular. I wonder if you could create a small explanation on how to do that in the contributor doc on checkers ?

I saw that extra options does not have documentation. So I decided to create separate PR adding all of them: #6947 . Marked as draft because it documents also shared extra option.

DanielNoord

Final nitpicks. Thanks @matusvalo 👍

DanielNoord · 2022-06-13T20:50:27Z

doc/exts/pylint_messages.py

@@ -7,7 +7,7 @@
 import os


@matusvalo Did you decide to do a follow-up? If so, could you open the issue?

doc/exts/pylint_messages.py

examples/deprecation_checker.py

pylint/checkers/base_checker.py

pylint/message/message_definition.py

tests/message/unittest_message_definition.py

Co-authored-by: Daniël van Noord <[email protected]>

github-actions · 2022-06-14T08:09:32Z

🤖 Effect of this PR on checked open source code: 🤖

Effect on black:
The following messages are now emitted:

deprecated-argument:
Using deprecated argument loop of method gather()
https://github.com/psf/black/blob/main/src/black/__init__.py#L878
deprecated-argument:
Using deprecated argument loop of method gather()
https://github.com/psf/black/blob/main/src/black/concurrency.py#L49

The following messages are no longer emitted:

deprecated-argument:
Using deprecated argument loop of method gather()
https://github.com/psf/black/blob/main/src/black/__init__.py#L878
deprecated-argument:
Using deprecated argument loop of method gather()
https://github.com/psf/black/blob/main/src/black/concurrency.py#L49

Effect on pandas:
The following messages are now emitted:

deprecated-module:
Deprecated module 'optparse'
https://github.com/pandas-dev/pandas/blob/main/pandas/util/_print_versions.py#L138

The following messages are no longer emitted:

deprecated-module:
Deprecated module 'optparse'
https://github.com/pandas-dev/pandas/blob/main/pandas/util/_print_versions.py#L138

Effect on sentry:
The following messages are now emitted:

deprecated-decorator:
Using deprecated decorator abc.abstractproperty()
https://github.com/getsentry/sentry/blob/master/src/sentry/unmerge.py#L62
deprecated-module:
Deprecated module 'distutils.version'
https://github.com/getsentry/sentry/blob/master/src/sentry/sdk_updates.py#L2
deprecated-module:
Deprecated module 'asyncore'
https://github.com/getsentry/sentry/blob/master/src/sentry/services/smtp.py#L1
deprecated-module:
Deprecated module 'smtpd'
https://github.com/getsentry/sentry/blob/master/src/sentry/services/smtp.py#L4
deprecated-method:
Using deprecated method currentThread()
https://github.com/getsentry/sentry/blob/master/src/sentry/debug/utils/thread_collector.py#L11
deprecated-method:
Using deprecated method currentThread()
https://github.com/getsentry/sentry/blob/master/src/sentry/debug/utils/thread_collector.py#L17
deprecated-method:
Using deprecated method currentThread()
https://github.com/getsentry/sentry/blob/master/src/sentry/debug/utils/thread_collector.py#L25
deprecated-method:
Using deprecated method currentThread()
https://github.com/getsentry/sentry/blob/master/src/sentry/debug/utils/thread_collector.py#L30
deprecated-decorator:
Using deprecated decorator abc.abstractproperty()
https://github.com/getsentry/sentry/blob/master/src/sentry/web/frontend/unsubscribe_notifications.py#L46
deprecated-decorator:
Using deprecated decorator abc.abstractproperty()
https://github.com/getsentry/sentry/blob/master/src/sentry/web/frontend/unsubscribe_notifications.py#L50
deprecated-method:
Using deprecated method getcallargs()
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/services.py#L298
deprecated-method:
Using deprecated method setDaemon()
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/pubsub.py#L40
deprecated-method:
Using deprecated method setDaemon()
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/metrics.py#L105
deprecated-module:
Deprecated module 'distutils'
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/base.py#L5
deprecated-module:
Deprecated module 'distutils.core'
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/base.py#L6
deprecated-module:
Deprecated module 'distutils'
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L8
deprecated-module:
Deprecated module 'distutils'
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L10
deprecated-module:
Deprecated module 'distutils'
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_integration_docs.py#L2
deprecated-method:
Using deprecated method getcallargs()
https://github.com/getsentry/sentry/blob/master/src/sentry/tsdb/redissnuba.py#L81
deprecated-module:
Deprecated module 'optparse'
https://github.com/getsentry/sentry/blob/master/src/sentry/management/commands/serve_normalize.py#L9
deprecated-method:
Using deprecated method setDaemon()
https://github.com/getsentry/sentry/blob/master/src/sentry/bgtasks/api.py#L58

The following messages are no longer emitted:

deprecated-decorator:
Using deprecated decorator abc.abstractproperty()
https://github.com/getsentry/sentry/blob/master/src/sentry/unmerge.py#L62
deprecated-module:
Deprecated module 'distutils.version'
https://github.com/getsentry/sentry/blob/master/src/sentry/sdk_updates.py#L2
deprecated-module:
Deprecated module 'asyncore'
https://github.com/getsentry/sentry/blob/master/src/sentry/services/smtp.py#L1
deprecated-module:
Deprecated module 'smtpd'
https://github.com/getsentry/sentry/blob/master/src/sentry/services/smtp.py#L4
deprecated-method:
Using deprecated method currentThread()
https://github.com/getsentry/sentry/blob/master/src/sentry/debug/utils/thread_collector.py#L11
deprecated-method:
Using deprecated method currentThread()
https://github.com/getsentry/sentry/blob/master/src/sentry/debug/utils/thread_collector.py#L17
deprecated-method:
Using deprecated method currentThread()
https://github.com/getsentry/sentry/blob/master/src/sentry/debug/utils/thread_collector.py#L25
deprecated-method:
Using deprecated method currentThread()
https://github.com/getsentry/sentry/blob/master/src/sentry/debug/utils/thread_collector.py#L30
deprecated-decorator:
Using deprecated decorator abc.abstractproperty()
https://github.com/getsentry/sentry/blob/master/src/sentry/web/frontend/unsubscribe_notifications.py#L46
deprecated-decorator:
Using deprecated decorator abc.abstractproperty()
https://github.com/getsentry/sentry/blob/master/src/sentry/web/frontend/unsubscribe_notifications.py#L50
deprecated-method:
Using deprecated method getcallargs()
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/services.py#L298
deprecated-method:
Using deprecated method setDaemon()
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/pubsub.py#L40
deprecated-method:
Using deprecated method setDaemon()
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/metrics.py#L105
deprecated-module:
Deprecated module 'distutils'
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/base.py#L5
deprecated-module:
Deprecated module 'distutils.core'
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/base.py#L6
deprecated-module:
Deprecated module 'distutils'
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L8
deprecated-module:
Deprecated module 'distutils'
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L10
deprecated-module:
Deprecated module 'distutils'
https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_integration_docs.py#L2
deprecated-method:
Using deprecated method getcallargs()
https://github.com/getsentry/sentry/blob/master/src/sentry/tsdb/redissnuba.py#L81
deprecated-module:
Deprecated module 'optparse'
https://github.com/getsentry/sentry/blob/master/src/sentry/management/commands/serve_normalize.py#L9
deprecated-method:
Using deprecated method setDaemon()
https://github.com/getsentry/sentry/blob/master/src/sentry/bgtasks/api.py#L58

This comment was generated for commit 7be4aab

DanielNoord

https://github.com/PyCQA/pylint/pull/6693/files#r896124542
https://github.com/PyCQA/pylint/pull/6693/files#r896129061

@matusvalo I think you resolved these without answering the questions in them. Or am I overseeing your answers somewhere?

matusvalo · 2022-06-11T11:13:01Z

pylint/checkers/deprecated.py

+        {"old_names": [("W1513", "old-deprecated-decorator")], "shared": True},
+    ),
+}
+


I splitted the messages because when documentation is generated, the messages attached to the checkers are discovered. I wanted to avoid to listing messages not emitted by checker in the documentation (e.g. ImportsChecker is using only deprecated-module)

pylint/checkers/stdlib.py

pylint/message/message_definition.py

matusvalo · 2022-06-11T11:19:53Z

doc/exts/pylint_messages.py

+        ):
+            shared_messages_list = list(shared_messages)
+            if len(shared_messages_list) > 1:
+                _write_single_shared_message_page(category_dir, shared_messages_list)


_write_single_shared_message_page is used when we have multiple checkers using the same message. Currently, there is no such message, but I added it to cover all cases.

pylint/checkers/deprecated.py

matusvalo · 2022-06-11T15:38:40Z

doc/exts/pylint_messages.py

@@ -7,7 +7,7 @@
 import os


The only thing I would add is to add all checkers that can emit a message to the page

If I understand your comment correctly, this is already implemented. See _write_single_shared_message_page and _write_single_message_page functions.

pylint/checkers/deprecated.py

pylint/message/message_definition.py

doc/exts/pylint_messages.py

matusvalo · 2022-06-15T06:03:48Z

doc/exts/pylint_messages.py

@@ -7,7 +7,7 @@
 import os


The only thing I would add is to add all checkers that can emit a message to the page. So for these messages both stdlib and imports. But that can also be done in a follow-up.

@DanielNoord not sure if I understand. Currently, all checkers emitting the message are showed. Currently, we don't have a Message that is used by multiple checkers, hence only one checker is showed for deprecated-* messages:

But the logic is universal, suppose we add to the Imports checker another message used by stdlib checker:

When we generate documentation with this code change, following page is showed:

matusvalo · 2022-06-16T05:59:08Z

https://github.com/PyCQA/pylint/pull/6693/files#r896124542 https://github.com/PyCQA/pylint/pull/6693/files#r896129061

@matusvalo I think you resolved these without answering the questions in them. Or am I overseeing your answers somewhere?

@DanielNoord My bad. I had pending review, for days and I missed that. I left you multiple messages waiting for publishing 🤦

DanielNoord · 2022-06-16T06:56:37Z

https://github.com/PyCQA/pylint/pull/6693/files#r896124542 https://github.com/PyCQA/pylint/pull/6693/files#r896129061
@matusvalo I think you resolved these without answering the questions in them. Or am I overseeing your answers somewhere?

@DanielNoord My bad. I had pending review, for days and I missed that. I left you multiple messages waiting for publishing 🤦

Well it seems I was mistaken as well. The only thing I was worried about was #6693 (comment) and you already fixed that before I even mentioned it.

Thanks for all the work here @matusvalo, LVGTM 👍

matusvalo · 2022-06-16T09:31:52Z

Thank you @DanielNoord @Pierre-Sassoulas for your review!

matusvalo and others added 3 commits May 25, 2022 01:35

Move message definitions from DeprecatedMixin

efce613

[pre-commit.ci] auto fixes from pre-commit.com hooks

6bc93ff

for more information, see https://pre-commit.ci

Added typing and fixed unittests

e3d1b6a

matusvalo and others added 2 commits May 25, 2022 02:34

Make DEPRECATED_MSGS and DEPRECATED_IMPORT_MSG class variables to mak…

15a9feb

…e pylint happy

[pre-commit.ci] auto fixes from pre-commit.com hooks

2ea5116

for more information, see https://pre-commit.ci

Pierre-Sassoulas added Bug 🪲 Documentation 📗 labels May 25, 2022

Pierre-Sassoulas added this to the 2.14.0 milestone May 25, 2022

Pierre-Sassoulas reviewed May 25, 2022

View reviewed changes

DanielNoord reviewed May 25, 2022

View reviewed changes

Pierre-Sassoulas modified the milestones: 2.14.0, 2.15.0 Jun 1, 2022

matusvalo and others added 2 commits June 3, 2022 23:07

Introduce shared messages

6f22a25

[pre-commit.ci] auto fixes from pre-commit.com hooks

208f179

for more information, see https://pre-commit.ci

This comment has been minimized.

Sign in to view

matusvalo added 3 commits June 7, 2022 00:44

Change Message codes in DeprecatedMixin to W49XX

3c68f04

Make mypy happy

3450de0

Make pylint happy

23442ff

This comment has been minimized.

Sign in to view

DanielNoord requested changes Jun 7, 2022

View reviewed changes

DanielNoord reviewed Jun 7, 2022

View reviewed changes

pylint/checkers/base_checker.py Outdated Show resolved Hide resolved

DanielNoord requested changes Jun 11, 2022

View reviewed changes

matusvalo and others added 2 commits June 11, 2022 13:25

Update doc/exts/pylint_messages.py

425a1c8

Co-authored-by: Daniël van Noord <[email protected]>

Update doc/exts/pylint_messages.py

14ff3da

Co-authored-by: Daniël van Noord <[email protected]>

matusvalo changed the title ~~Move message definitions from DeprecatedMixin~~ Add support of sharing message in multiple checkers. Fix DeprecatedChecker example Jun 11, 2022

This comment has been minimized.

Sign in to view

Pierre-Sassoulas reviewed Jun 11, 2022

View reviewed changes

matusvalo added 2 commits June 11, 2022 17:51

Make messages static class attributes

a8d2392

Merge branch 'fix_deprecated_example' of https://github.com/matusvalo…

6c5ccd9

…/pylint into fix_deprecated_example

This comment has been minimized.

Sign in to view

Keep MessageDefinition backward compatible

2a65a88

matusvalo mentioned this pull request Jun 11, 2022

Pass extra parameters of MessageDefinition as dictionary instead of separate paramters #6918

Open

This comment has been minimized.

Sign in to view

matusvalo mentioned this pull request Jun 13, 2022

[Docs] Move Message definition to separate section, add extra options #6947

Merged

matusvalo requested review from DanielNoord and Pierre-Sassoulas June 13, 2022 20:47

DanielNoord requested changes Jun 13, 2022

View reviewed changes

Apply suggestions from code review

7be4aab

Co-authored-by: Daniël van Noord <[email protected]>

Pierre-Sassoulas mentioned this pull request Jun 14, 2022

Allow five digit message id's (and possibly disallow four digit id's) #5275

Open

matusvalo requested a review from DanielNoord June 15, 2022 17:23

DanielNoord requested changes Jun 15, 2022

View reviewed changes

matusvalo commented Jun 16, 2022

View reviewed changes

DanielNoord approved these changes Jun 16, 2022

View reviewed changes

matusvalo merged commit e666506 into pylint-dev:main Jun 16, 2022

matusvalo deleted the fix_deprecated_example branch June 16, 2022 09:32


		msgs: dict[str, MessageDefinitionTuple] = {
		DEPRECATED_MSGS: dict[str, MessageDefinitionTuple] = {

	DEPRECATED_MSGS: dict[str, MessageDefinitionTuple] = {
	DEPRECATED_MSGS_STDLIB: dict[str, MessageDefinitionTuple] = {

Add support of sharing message in multiple checkers. Fix DeprecatedChecker example #6693

Add support of sharing message in multiple checkers. Fix DeprecatedChecker example #6693

Conversation

matusvalo commented May 24, 2022 • edited Loading

Type of Changes

Description

coveralls commented May 25, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2493613951

💛 - Coveralls

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

matusvalo commented May 25, 2022

Pierre-Sassoulas commented May 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DanielNoord commented Jun 2, 2022 • edited Loading

matusvalo commented Jun 3, 2022

DanielNoord commented Jun 3, 2022

matusvalo commented Jun 3, 2022

matusvalo commented Jun 3, 2022

This comment has been minimized.

DanielNoord commented Jun 4, 2022

This comment has been minimized.

DanielNoord left a comment

Choose a reason for hiding this comment

matusvalo commented Jun 11, 2022

DanielNoord left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

matusvalo commented Jun 13, 2022

DanielNoord left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 14, 2022

DanielNoord left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matusvalo commented Jun 16, 2022

DanielNoord commented Jun 16, 2022

matusvalo commented Jun 16, 2022

matusvalo commented May 24, 2022 •

edited

Loading

coveralls commented May 25, 2022 •

edited

Loading

Pierre-Sassoulas commented May 25, 2022 •

edited

Loading

DanielNoord commented Jun 2, 2022 •

edited

Loading