Run and upload primer over packages #6714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2397704965
💛 - Coveralls |
| arguments += [f"--rcfile={data.pylintrc_relpath}"] | ||
| output = StringIO() | ||
| reporter = JSONReporter(output) | ||
| Run(arguments, reporter=reporter, do_exit=False) |
There was a problem hiding this comment.
We don't want to lint every primer package twice, so I think we will need to turn off the python test that checks for crashes, yeah?
There was a problem hiding this comment.
Yes! Although this still needs some work before we get there. We don't actually prime on astroid and black doesn't take too long. So for now I think this is fine.
Co-authored-by: Jacob Walls <[email protected]>
for more information, see https://pre-commit.ci
|
Should we bump |
Pierre-Sassoulas
approved these changes
May 27, 2022
There was a problem hiding this comment.
LGTM,, but I think @jacobtylerwalls is right that we should try to remove the package from the normal primer if they are in the false positive primer.
| @@ -26,14 +26,16 @@ jobs: | |||
| steps: | |||
| - name: Check out code from GitHub | |||
| uses: actions/[email protected] | |||
| with: | |||
| fetch-depth: 0 | |||
jacobtylerwalls
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Ref. #5364.
Next step for the primer.
Test run on local
main:https://github.com/DanielNoord/pylint/actions/runs/2396609324
Test run on a PR:
https://github.com/DanielNoord/pylint/actions/runs/2396610764
Basically, the PR run will now result in three files: the PR number, the output of the primer on the PR and the output of the
mainrun against which the PR is being compared.This can be downloaded by a last and final step which takes all these files. Compares them and then comments on the relevant PR.