Fail "new primer" runs on fatal errors, like "old primer" #6746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Pull Request Test Coverage Report for Build 2411224946
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
approved these changes
May 30, 2022
DanielNoord
reviewed
May 30, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
DanielNoord
reviewed
May 30, 2022
jacobtylerwalls
commented
May 30, 2022
|
This will need a preparatory commit on main to make sure all astroid failures are re-raised as a flavor of |
This comment has been minimized.
This comment has been minimized.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Here's a proof of concept showing a passing CI job on the primer and an Actions warning annotation with the traceback from astroid: Run / 3.8 |
jacobtylerwalls
commented
May 30, 2022
DanielNoord
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
The old primer did one thing very well -- it failed CI jobs when encountering
fatalerrors during the linting of open source packages, whether caused in new pylint or astroid PRs, or when adding new packages to the primer, or when third-party packages pushed new changes.The new primer needs some analogous functionality -- something beyond the message differ. If some fatal errors "sneak in" (we merge a PR without noticing the change, or we believe it to be related to a different PR, or incompatible PRs are merged, or we add a package, or third-party maintainers publish new commits), we don't want
nfatal errors on main to silently matchnfatal errors on a PR and for the comment-bot to stay quiet about it. We want a failure.I persuaded (💪🏻 😅 🙏🏻 📈 ) us into running the primer on bleeding-edge astroid, and from the feedback that we want to be careful not to introduce a dependency in pylint's CI on bleeding-edge astroid with respect to failing jobs (because that is more significant than simply the contents of a bot's comments on a PR), I filter those out here and just issue a warning instead.