Skip to content

Add the coverage package to the primer suite. #7683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2022

Conversation

mbyrnepr2
Copy link
Member

Type of Changes

Description

Adding the package to the primer test suite as discussed.

Refs #5359

@mbyrnepr2 mbyrnepr2 added Skip news 🔇 This change does not require a changelog entry primer Maintenance Discussion or action around maintaining pylint or the dev workflow Enhancement ✨ Improvement to a component labels Oct 27, 2022
@mbyrnepr2 mbyrnepr2 added this to the 2.16.0 milestone Oct 27, 2022
@coveralls
Copy link

coveralls commented Oct 27, 2022

Pull Request Test Coverage Report for Build 3335885262

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.359%

Totals Coverage Status
Change from base Build 3335470509: 0.0%
Covered Lines: 17178
Relevant Lines: 18014

💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.16.0 milestone Oct 27, 2022
@Pierre-Sassoulas
Copy link
Member

(Regarding the milestone, we're trying to remove documentation/maintenance/skip news from the milestone so it's easier to look what is in a release in github)

@mbyrnepr2 mbyrnepr2 removed Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Oct 27, 2022
@mbyrnepr2
Copy link
Member Author

mbyrnepr2 commented Oct 27, 2022

(Regarding the milestone, we're trying to remove documentation/maintenance/skip news from the milestone so it's easier to look what is in a release in github)

Ok clear - I've added a fragment & removed the skip news & maintenance labels.
Edit: the fragment should be on the remote branch - I don't see it here yet.
Edit edit: Close/re-open & it appears now :D

@mbyrnepr2 mbyrnepr2 closed this Oct 27, 2022
@mbyrnepr2 mbyrnepr2 reopened this Oct 27, 2022
@mbyrnepr2 mbyrnepr2 marked this pull request as ready for review October 27, 2022 08:35
@Pierre-Sassoulas
Copy link
Member

Sorry I meant it's better to not define the milestone for maintenance issue or issue with skip news so the gtihub milestone is not flooded with non user facing merge request. This is why I removed the 2.16.0 milestone previously. You were right to add skip news and maintenance, this does not need to be documented :)

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry and removed Enhancement ✨ Improvement to a component labels Oct 27, 2022
@mbyrnepr2
Copy link
Member Author

Sorry I meant it's better to not define the milestone for maintenance issue or issue with skip news so the gtihub milestone is not flooded with non user facing merge request. This is why I removed the 2.16.0 milestone previously. You were right to add skip news and maintenance, this does not need to be documented :)

Its too early for me haha! Of course I'll remove the fragment.

@mbyrnepr2 mbyrnepr2 closed this Oct 27, 2022
@mbyrnepr2 mbyrnepr2 reopened this Oct 27, 2022
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbyrnepr2 mbyrnepr2 merged commit efc9033 into pylint-dev:main Oct 27, 2022
@mbyrnepr2 mbyrnepr2 deleted the add_coverage_to_primer_suite branch October 27, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow primer Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants