Clear LRU caches on pylint utilities #8420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
previously approved these changes
Mar 10, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8420 +/- ##
=======================================
Coverage 95.71% 95.72%
=======================================
Files 175 175
Lines 18451 18462 +11
=======================================
+ Hits 17660 17672 +12
+ Misses 791 790 -1
|
Pierre-Sassoulas
previously approved these changes
Mar 10, 2023
There was a problem hiding this comment.
LGTM ! Thanks for creating the label, when we release we change the one already backported one to "backported" and we could rename to old one or delete the old one / create the new one. I was in the process of doing just that and thought I should upgrade the release.md but then apparently got distracted by a squirrel π I realize now that I did not clean up readthedoc versions either, so this was a fruitful review.
Pierre-Sassoulas
added a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Mar 10, 2023
Guard _lru_cache_wrapper under TYPE_CHECKING
jacobtylerwalls
dismissed stale reviews from Pierre-Sassoulas and DanielNoord
via
202f282
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
previously approved these changes
Mar 10, 2023
Pierre-Sassoulas
added a commit
that referenced
this pull request
Mar 10, 2023
Refs #8420 Co-authored-by: Jacob Walls <[email protected]>
jacobtylerwalls
commented
Mar 10, 2023
Pierre-Sassoulas
approved these changes
Mar 10, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
(cherry picked from commit ab20812)
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit f8206be |
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Mar 10, 2023
(cherry picked from commit ab20812) Co-authored-by: Jacob Walls <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #8361
Created a new backport label (should I have?)