-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix bug with unclear function signature #8668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with unclear function signature #8668
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8668 +/- ##
=======================================
Coverage 95.84% 95.85%
=======================================
Files 173 173
Lines 18492 18510 +18
=======================================
+ Hits 17724 17742 +18
Misses 768 768
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ! I think formatting the args make sense (it seems like it could be a performance hit a lot is done in this function). It does simplify the code and fix the issue though... Could you add a fragment for the changelog, please ?
Agree. Let's try just comparing argnames() instead. |
This comment has been minimized.
This comment has been minimized.
We're touching |
π€ Effect of this PR on checked open source code: π€ Effect on pandas:
This comment was generated for commit 8a5e049 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primer looks great !
Type of Changes
Description
Fixes long open issue of getting tensorflow function signatures incorrect and producing false positives. Due to import/function definition of tensorflow functions sometimes infer finds multiple function definitions and picks wrong one. safe_infer does check that each function definition has same number of arguments, but it's possible the names/defaults vary.
Also added a few simple test cases. I manually tested with tf.concat and confirmed it fixed that false positive.
Closes #3613