Avoid duplicate overgeneral-exceptions warnings with --jobs
#8702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8702 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 172 172
Lines 18320 18320
=======================================
Hits 17553 17553
Misses 767 767
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 58348a1 |
DanielNoord
approved these changes
May 19, 2023
| @@ -102,6 +103,19 @@ def _config_initialization( | |||
| "unrecognized-option", args=unrecognized_options_message, line=0 | |||
| ) | |||
|
|
|||
| # TODO 3.1: Change this to emit unknown-option-value | |||
There was a problem hiding this comment.
I think this need to be removed from pylint and moved to the config upgrader. Doing those kind of checks at runtime is costly and unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This warning was emitted multiple times when running with
--jobs, e.g. thousands of times (not just number of jobs).It's a configuration sanity check: it belongs in the linter, not in the actual checker.
Closes #7774