[config] Create a config parsing class indpendant from Pylinter #8707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8707 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 173 173
Lines 18378 18381 +3
=======================================
+ Hits 17610 17613 +3
Misses 768 768
|
This comment has been minimized.
This comment has been minimized.
|
I think I like the alternate way more. Cleaner final result it's harder to badly instantiate the classes. |
|
Yes, let's go for the alternative! Nice solution. One early review comment, let's make the new class private (or perhaps even just make the whole file private by underscoring it). I never want to deal with |
This will permit to parse config file without having to instantiate a linter for tool working on pylint configuration like #5462
Pierre-Sassoulas
force-pushed
the
refactor-config-parsing
branch
from
ed8f2ac to
e24e936
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
force-pushed
the
refactor-config-parsing
branch
from
9027cde to
12299ee
Compare
Pierre-Sassoulas
force-pushed
the
refactor-config-parsing
branch
from
12299ee to
398982c
Compare
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 398982c |
DanielNoord
approved these changes
May 22, 2023
Pierre-Sassoulas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This will permit to parse config file without having to instantiate a linter for tool working on pylint configuration like #5462. another way to do this would be to extract the logic and create another class that we could use in
_ConfigurationFileParserlike here: Pierre-Sassoulas@4ccbee1