[ci] Add jobs for python 3.12-beta following its release

.github/workflows/primer-test.yaml

@@ -30,7 +30,7 @@ jobs:
     timeout-minutes: 5
     strategy:
       matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11"]
+        python-version: [3.8, 3.9, "3.10", "3.11", "3.12-dev"]
     outputs:
       python-key: ${{ steps.generate-python-key.outputs.key }}
     steps:
@@ -72,7 +72,7 @@ jobs:
     needs: prepare-tests-linux
     strategy:
       matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11"]
+        python-version: [3.8, 3.9, "3.10", "3.11", "3.12-dev"]
     steps:
       - name: Check out code from GitHub
         uses: actions/[email protected]

.github/workflows/tests.yaml

@@ -31,7 +31,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11"]
+        python-version: [3.8, 3.9, "3.10", "3.11", "3.12-dev"]
     outputs:
       python-key: ${{ steps.generate-python-key.outputs.key }}
     steps:
@@ -175,7 +175,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11"]
+        python-version: [3.8, 3.9, "3.10", "3.11", "3.12-dev"]
     steps:
       - name: Set temp directory
         run: echo "TEMP=$env:USERPROFILE\AppData\Local\Temp" >> $env:GITHUB_ENV

CONTRIBUTORS.txt

@@ -103,10 +103,10 @@ contributors:
 - Tushar Sadhwani <[email protected]> (tusharsadhwani)
 - Nicolas Chauvat <[email protected]>
 - orSolocate <[email protected]>
+- Zen Lee <[email protected]>
 - Radu Ciorba <[email protected]>: not-context-manager and confusing-with-statement warnings.
 - Holger Peters <[email protected]>
 - Cosmin Poieană <[email protected]>: unichr-builtin and improvements to bad-open-mode.
-- Zen Lee <[email protected]>
 - Steven Myint <[email protected]>: duplicate-except.
 - Peter Kolbus <[email protected]> (Garmin)
 - Luigi Bertaco Cristofolini <[email protected]> (luigibertaco)
@@ -118,16 +118,17 @@ contributors:
 - Julien Jehannet <[email protected]>
 - Boris Feld <[email protected]>
 - Anthony Sottile <[email protected]>
+- Robert Hofer <[email protected]>
 - Pedro Algarvio <[email protected]> (s0undt3ch)
 - Julien Palard <[email protected]>
 - David Liu <[email protected]> (david-yz-liu)
 - Dan Goldsmith <[email protected]>: support for msg-template in HTML reporter.
 - Buck Evan <[email protected]>
-- Robert Hofer <[email protected]>
 - Mariatta Wijaya <[email protected]>
   * Added new check `logging-fstring-interpolation`
   * Documentation typo fixes
 - Jakub Wilk <[email protected]>
+- Hugo van Kemenade <[email protected]>
 - Eli Fine <[email protected]> (eli88fine): Fixed false positive duplicate code warning for lines with symbols only
 - Andrew Haigh <[email protected]> (nelfin)
 - Émile Crater <[email protected]>
@@ -138,10 +139,10 @@ contributors:
 - Marianna Polatoglou <[email protected]>: minor contribution for wildcard import check
 - Manuel Vázquez Acosta <[email protected]>
 - Luis Escobar <[email protected]> (Vauxoo): Add bad-docstring-quotes and docstring-first-line-empty
+- Lucas Cimon <[email protected]>
 - Konstantina Saketou <[email protected]>
 - Konstantin <[email protected]>
 - Jim Robertson <[email protected]>
-- Hugo van Kemenade <[email protected]>
 - Ethan Leba <[email protected]>
 - Enji Cooper <[email protected]>
 - Drum Ogilvie <[email protected]>
@@ -219,7 +220,6 @@ contributors:
   * Fixed ignored empty functions by similarities checker with "ignore-signatures" option enabled
   * Ignore function decorators signatures as well by similarities checker with "ignore-signatures" option enabled
   * Ignore class methods and nested functions signatures as well by similarities checker with "ignore-signatures" option enabled
-- Lucas Cimon <[email protected]>
 - Kylian <[email protected]>
 - Konstantin Manna <[email protected]>
 - Kai Mueller <[email protected]>
@@ -363,6 +363,7 @@ contributors:
 - Viorel Știrbu <[email protected]>: intern-builtin warning.
 - VictorT <[email protected]>
 - Victor Jiajunsu <[email protected]>
+- ViRuSTriNiTy <[email protected]>
 - Trevor Bekolay <[email protected]>
   * Added --list-msgs-enabled command
 - Tomer Chachamu <[email protected]>: simplifiable-if-expression
@@ -428,6 +429,7 @@ contributors:
 - Moody <[email protected]>
 - Mitchell Young <[email protected]>: minor adjustment to docparams
 - Mitar <[email protected]>
+- Mikhail f. Shiryaev <[email protected]>
 - Mike Fiedler <[email protected]> (miketheman)
 - Mike Bryant <[email protected]>
 - Michka Popoff <[email protected]>
@@ -476,6 +478,7 @@ contributors:
   * Fixed `toml` dependency issue
 - Jeremy Fleischman <[email protected]>
 - Jason Owen <[email protected]>
+- Jason Lau <[email protected]>
 - Jared Garst <[email protected]>
 - Jared Deckard <[email protected]>
 - Janne Rönkkö <[email protected]>
@@ -553,6 +556,7 @@ contributors:
 - Arun Persaud <[email protected]>
 - Arthur Lutz <[email protected]>
 - Antonio Ossa <[email protected]>
+- Antonio <[email protected]>
 - Anthony VEREZ <[email protected]>
 - Anthony Tan <[email protected]>
 - Anthony Foglia <[email protected]> (Google): Added simple string slots check.

doc/user_guide/checkers/features.rst

@@ -108,6 +108,9 @@ Basic checker Messages
   Used when a break or a return statement is found inside the finally clause of
   a try...finally block: the exceptions raised in the try clause will be
   silently swallowed instead of being re-raised.
+:return-in-finally (W0134): *'return' shadowed by the 'finally' clause.*
+  Emitted when a 'return' statement is found in a 'finally' block. This will
+  overwrite the return value of a function and should be avoided.
 :assert-on-tuple (W0199): *Assert called on a populated tuple. Did you mean 'assert x,y'?*
   A call of assert on a tuple will always evaluate to true if the tuple is not
   empty, and will always evaluate to false if it is.

doc/user_guide/messages/messages_overview.rst

@@ -309,6 +309,7 @@ All messages in the warning category:
    warning/redundant-unittest-assert
    warning/redundant-yields-doc
    warning/reimported
+   warning/return-in-finally
    warning/self-assigning-variable
    warning/self-cls-assignment
    warning/shadowed-import

doc/whatsnew/fragments/8416.breaking

@@ -1,3 +1,3 @@
-``pyreverse``: Support for the ``.vcg`` output format (Visualaization of Compiler Graphs) has been dropped.
+``pyreverse``: Support for the ``.vcg`` output format (Visualization of Compiler Graphs) has been dropped.
 
 Closes #8416

doc/whatsnew/fragments/8718.other

@@ -0,0 +1,3 @@
+Pylint now supports python 3.12.
+
+Refs #8718

pylint/checkers/base/name_checker/checker.py

@@ -603,12 +603,17 @@ def _assigns_typealias(node: nodes.NodeNG | None) -> bool:
         """Check if a node is assigning a TypeAlias."""
         inferred = utils.safe_infer(node)
         if isinstance(inferred, nodes.ClassDef):
-            if inferred.qname() == ".Union":
+            qname = inferred.qname()
+            if qname == "typing.TypeAlias":
+                return True
+            if qname == ".Union":
                 # Union is a special case because it can be used as a type alias
                 # or as a type annotation. We only want to check the former.
                 assert node is not None
                 return not isinstance(node.parent, nodes.AnnAssign)
         elif isinstance(inferred, nodes.FunctionDef):
+            # TODO: when py3.12 is minimum, remove this condition
+            # TypeAlias became a class in python 3.12
             if inferred.qname() == "typing.TypeAlias":
                 return True
         return False

pylint/checkers/classes/class_checker.py

@@ -1707,7 +1707,8 @@ def _check_in_slots(self, node: nodes.AssignAttr) -> None:
         # If any ancestor doesn't use slots, the slots
         # defined for this class are superfluous.
         if any(
-            "__slots__" not in ancestor.locals and ancestor.name != "object"
+            "__slots__" not in ancestor.locals
+            and ancestor.name not in ("Generic", "object")
             for ancestor in klass.ancestors()
         ):
             return

pylint/constants.py

@@ -17,6 +17,7 @@
 PY38_PLUS = sys.version_info[:2] >= (3, 8)
 PY39_PLUS = sys.version_info[:2] >= (3, 9)
 PY310_PLUS = sys.version_info[:2] >= (3, 10)
+PY312_PLUS = sys.version_info[:2] >= (3, 12)
 
 IS_PYPY = platform.python_implementation() == "PyPy"
 

pylint/lint/pylinter.py

@@ -1043,7 +1043,13 @@ def _check_astroid_module(
         try:
             tokens = utils.tokenize_module(node)
         except tokenize.TokenError as ex:
-            self.add_message("syntax-error", line=ex.args[1][0], args=ex.args[0])
+            self.add_message(
+                "syntax-error",
+                line=ex.args[1][0],
+                col_offset=ex.args[1][1],
+                args=ex.args[0],
+                confidence=HIGH,
+            )
             return None
 
         if not node.pure_python:

pyproject.toml

@@ -1,5 +1,5 @@
 [build-system]
-requires = ["setuptools~=62.6", "wheel~=0.37.1"]
+requires = ["setuptools~=66.1", "wheel~=0.37.1"]
 build-backend = "setuptools.build_meta"
 
 [project]
@@ -24,6 +24,7 @@ classifiers = [
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
+    "Programming Language :: Python :: 3.12",
     "Programming Language :: Python :: Implementation :: CPython",
     "Programming Language :: Python :: Implementation :: PyPy",
     "Topic :: Software Development :: Debuggers",
@@ -35,6 +36,7 @@ requires-python = ">=3.8.0"
 dependencies    = [
     "dill>=0.2;python_version<'3.11'",
     "dill>=0.3.6;python_version>='3.11'",
+    "dill @ git+https://github.com/uqfoundation/dill.git@83ab36ce3e8cfcc0224aa99d5249a5e8f1c22590 ; python_version>='3.12'",
     "platformdirs>=2.2.0",
     # Also upgrade requirements_test_min.txt.
     # Pinned to dev of second minor update to allow editable installs and fix primer issues,
@@ -74,6 +76,13 @@ license-files = ["LICENSE", "CONTRIBUTORS.txt"]  # Keep in sync with setup.cfg
 [tool.setuptools.packages.find]
 include = ["pylint*"]
 
+[tool.setuptools.package-dir]
+# Simulate editable_mode=compat, described at:
+# https://github.com/pypa/setuptools/issues/3767
+# TODO: remove after solving root cause described at:
+# https://github.com/pylint-dev/pylint/issues/8854
+"" = "."
+
 [tool.setuptools.package-data]
 pylint = ["testutils/testing_pylintrc", "py.typed"]
 

tests/functional/d/deprecated/deprecated_module_py310.rc

@@ -1,2 +1,3 @@
 [testoptions]
 min_pyver = 3.10
+max_pyver = 3.12

tests/functional/d/deprecated/deprecated_module_redundant.py

@@ -1,3 +1,3 @@
 """This deprecated stdlib module is redundantly given by the user in the config."""
 # pylint: disable-next=unused-import
-import imp  # [deprecated-module]
+import optparse  # [deprecated-module]

tests/functional/d/deprecated/deprecated_module_redundant.rc

@@ -1,2 +1,2 @@
 [Imports]
-deprecated-modules=imp
+deprecated-modules=optparse

tests/functional/d/deprecated/deprecated_module_redundant.txt

@@ -1 +1 @@
-deprecated-module:3:0:3:10::Deprecated module 'imp':UNDEFINED
+deprecated-module:3:0:3:15::Deprecated module 'optparse':UNDEFINED

tests/functional/e/enum_self_defined_member_5138.rc

@@ -0,0 +1,3 @@
+[testoptions]
+# https://github.com/python/cpython/issues/106762
+max_pyver=3.12

tests/functional/r/regression_02/regression_distutil_import_error_73.rc

@@ -0,0 +1,2 @@
+[testoptions]
+max_pyver=3.12

tests/functional/t/tokenize_error.py

@@ -1,6 +1,4 @@
-"""A module that is accepted by Python but rejected by tokenize.
-
-The problem is the trailing line continuation at the end of the line,
+"""The problem is the trailing line continuation at the end of the line,
 which produces a TokenError."""
 # +2: [syntax-error]
 ""\

tests/functional/t/tokenize_error.rc

@@ -1 +1,2 @@
 [testoptions]
+max_pyver=3.12

tests/functional/t/tokenize_error.txt

@@ -1 +1 @@
-syntax-error:7:0:None:None::EOF in multi-line statement:UNDEFINED
+syntax-error:5:0:None:None::EOF in multi-line statement:HIGH

tests/functional/t/tokenize_error_py312.py

@@ -0,0 +1,4 @@
+"""The problem is the trailing line continuation at the end of the line,
+which produces a TokenError."""
+# +1: [syntax-error]
+""\

tests/functional/t/tokenize_error_py312.rc

@@ -0,0 +1,2 @@
+[testoptions]
+min_pyver=3.12

tests/functional/t/tokenize_error_py312.txt

@@ -0,0 +1 @@
+syntax-error:4:4:None:None::unexpected EOF in multi-line statement:HIGH

tests/functional/u/unhashable_member.py

@@ -8,7 +8,6 @@ class Unhashable:
 {}[[1, 2, 3]] # [unhashable-member]
 {}[{}] # [unhashable-member]
 {}[Unhashable()] # [unhashable-member]
-{}[1:2]  # [unhashable-member]
 {'foo': 'bar'}['foo']
 {'foo': 'bar'}[42]
 

tests/functional/u/unhashable_member.txt

@@ -1,8 +1,7 @@
 unhashable-member:8:0:8:2::'[1, 2, 3]' is unhashable and can't be used as a key in a dict:INFERENCE
 unhashable-member:9:0:9:2::'{}' is unhashable and can't be used as a key in a dict:INFERENCE
 unhashable-member:10:0:10:2::'Unhashable()' is unhashable and can't be used as a key in a dict:INFERENCE
-unhashable-member:11:0:11:2::"'1:2' is unhashable and can't be used as a key in a dict":INFERENCE
-unhashable-member:16:1:16:10::'[1, 2, 3]' is unhashable and can't be used as a key in a dict:INFERENCE
-unhashable-member:18:4:18:13::'[1, 2, 3]' is unhashable and can't be used as a key in a dict:INFERENCE
-unhashable-member:19:4:19:13::'[4, 5, 6]' is unhashable and can't be used as a key in a dict:INFERENCE
-unhashable-member:21:1:21:10::'[1, 2, 3]' is unhashable and can't be used as a member in a set:INFERENCE
+unhashable-member:15:1:15:10::'[1, 2, 3]' is unhashable and can't be used as a key in a dict:INFERENCE
+unhashable-member:17:4:17:13::'[1, 2, 3]' is unhashable and can't be used as a key in a dict:INFERENCE
+unhashable-member:18:4:18:13::'[4, 5, 6]' is unhashable and can't be used as a key in a dict:INFERENCE
+unhashable-member:20:1:20:10::'[1, 2, 3]' is unhashable and can't be used as a member in a set:INFERENCE

tests/functional/u/unhashable_member_py312.py

@@ -0,0 +1,2 @@
+"""slices can be used as dict keys from python 3.12"""
+var = {}[1:2]

tests/functional/u/unhashable_member_py312.rc

@@ -0,0 +1,2 @@
+[testoptions]
+min_pyver = 3.12

tests/test_functional.py

@@ -13,6 +13,7 @@
 from _pytest.config import Config
 
 from pylint import testutils
+from pylint.constants import PY312_PLUS
 from pylint.testutils import UPDATE_FILE, UPDATE_OPTION
 from pylint.testutils.functional import (
     FunctionalTestFile,
@@ -50,7 +51,8 @@ def test_functional(test_file: FunctionalTestFile, pytestconfig: Config) -> None
     lint_test.setUp()
 
     if test_file.base in TEST_WITH_EXPECTED_DEPRECATION:
-        with pytest.warns(DeprecationWarning, match="invalid escape sequence"):
+        exception_type = SyntaxWarning if PY312_PLUS else DeprecationWarning
+        with pytest.warns(exception_type, match="invalid escape sequence"):
             lint_test.runTest()
     else:
         lint_test.runTest()