Skip to content

[Backport maintenance/2.17.x] Fix a crash when nonlocal is defined at module level #8742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2023

Backport 33d3f22 from #8737.

* Fix a crash when a ``nonlocal`` is defined at module-level.

Closes #8735

(cherry picked from commit 33d3f22)
@Pierre-Sassoulas Pierre-Sassoulas added the Crash 💥 A bug that makes pylint crash label Jun 6, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.17.5 milestone Jun 6, 2023
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) June 6, 2023 19:12
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #8742 (c9989c7) into maintenance/2.17.x (c1243cf) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           maintenance/2.17.x    #8742   +/-   ##
===================================================
  Coverage               95.56%   95.56%           
===================================================
  Files                     178      178           
  Lines                   18812    18812           
===================================================
  Hits                    17978    17978           
  Misses                    834      834           
Impacted Files Coverage Δ
pylint/checkers/variables.py 97.17% <100.00%> (ø)

@Pierre-Sassoulas Pierre-Sassoulas merged commit 7b1242c into maintenance/2.17.x Jun 6, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-8737-to-maintenance/2.17.x branch June 6, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crash 💥 A bug that makes pylint crash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants