Skip to content

[Backport maintenance/2.17.x] Fix a crash when __all__ exists but cannot be inferred #8743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/whatsnew/fragments/8740.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix a crash when ``__all__`` exists but cannot be inferred.

Closes #8740
5 changes: 4 additions & 1 deletion pylint/checkers/variables.py
Original file line number Diff line number Diff line change
Expand Up @@ -2982,7 +2982,10 @@ def _check_module_attrs(
def _check_all(
self, node: nodes.Module, not_consumed: dict[str, list[nodes.NodeNG]]
) -> None:
assigned = next(node.igetattr("__all__"))
try:
assigned = next(node.igetattr("__all__"))
except astroid.InferenceError:
return
if isinstance(assigned, util.UninferableBase):
return
if assigned.pytype() not in {"builtins.list", "builtins.tuple"}:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
"""Edge case: __all__ exists in module's locals, but cannot be inferred.

Other tests for undefined-all-variable in tests/functional/n/names_in__all__.py"""

__all__ += [] # [undefined-variable]
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
undefined-variable:5:0:5:7::Undefined variable '__all__':UNDEFINED