Skip to content

[Backport maintenance/2.17.x] Fix a false positive for unused-variable #8744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2023

Backport e5584d5 from #8713.

@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Jun 6, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.17.5 milestone Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #8744 (4fa4c91) into maintenance/2.17.x (9c45686) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           maintenance/2.17.x    #8744   +/-   ##
===================================================
  Coverage               95.56%   95.56%           
===================================================
  Files                     178      178           
  Lines                   18815    18817    +2     
===================================================
+ Hits                    17981    17983    +2     
  Misses                    834      834           
Impacted Files Coverage Δ
pylint/checkers/variables.py 97.18% <100.00%> (+<0.01%) ⬆️

…in a ``if TYPE_CHECKING:`` block and ``allow-global-unused-variables`` is set to ``no`` in the configuration. (#8713)

Closes #8696

(cherry picked from commit e5584d5)
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the backport-8713-to-maintenance/2.17.x branch from 77d45ae to 4fa4c91 Compare June 6, 2023 20:59
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) June 6, 2023 21:00
@Pierre-Sassoulas Pierre-Sassoulas merged commit f37d4cb into maintenance/2.17.x Jun 6, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-8713-to-maintenance/2.17.x branch June 6, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants