Fix false negative for consider-using-augmented-assign on dicts/lists
#8964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8964 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 173 173
Lines 18592 18604 +12
=======================================
+ Hits 17802 17815 +13
+ Misses 790 789 -1
|
crazybolillo
force-pushed
the
i8959-crazybolillo
branch
3 times, most recently
from
5d3355b to
a5659dd
Compare
crazybolillo
changed the title
consider-using-augmented-assign on dicts
crazybolillo
changed the title
consider-using-augmented-assign on dicts/lists
crazybolillo
force-pushed
the
i8959-crazybolillo
branch
4 times, most recently
from
0a010dc to
06926b6
Compare
Assignments on dictionaries or lists which used the same subscripts were not generating `consider-using-augmented-assign` messages. This has been fixed. Closes pylint-dev#8959.
Pierre-Sassoulas
added
the
Needs review π
Pierre-Sassoulas
approved these changes
Aug 23, 2023
Pierre-Sassoulas
added
False Negative π¦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignments on dictionaries which used the same slices were not generating
consider-using-augmented-assignmessages. This has been fixed.Closes #8959.
Type of Changes