-
-
Notifications
You must be signed in to change notification settings - Fork 267
hierarchical partial pooling #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I was working on hierarchical partial pooling last week for a talk proposal!! I'll be happy to take this up, assigning myself if that's okay |
That would be great. The only change I had in mind however relies on ArviZ>0.11.2 which I think should be released any day now that gsoc is over? cc @canyon289 was also the release manager here |
@mjhajharia Assigning yourself is great. Well probably release arviz before youre done with your talk which is good. It means when you give your talk people will be able to use the notebook immediately |
Working on this with @PrinceAsiedu |
* add argument parser * extend argument parser * prepare a valid fixture * improve fixture * improve fixture * use simplex transform for the test case * add parse args * add flatten util * fix typo * refactor flattening * add mean chol * add test for mvn_prior * test final api * add additional argument * add type hints * fix tests * add a docstring * add to docs * simplify implementation * Update pymc_experimental/utils/prior.py Co-authored-by: Oriol Abril-Pla <[email protected]> * Update pymc_experimental/utils/prior.py Co-authored-by: Oriol Abril-Pla <[email protected]> * update the docstring * update the docstring Co-authored-by: Oriol Abril-Pla <[email protected]>
File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/case_studies/hierarchical_partial_pooling.ipynb
Reviewers: @OriolAbril
Changes for discussion
Changes listed in this section are up for discussion, these are ideas on how to improve
the notebook but may not have a clear implementation, or fix some know issue only partially.
ArviZ related
plot_forest
to avoid having to manually set the yticklabels. We'd instead use coords for that.Notes
Exotic dependencies
None
Computing power
Model runs in roughly a minute
The text was updated successfully, but these errors were encountered: