Skip to content

hierarchical partial pooling #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OriolAbril opened this issue Mar 29, 2021 · 4 comments
Closed

hierarchical partial pooling #56

OriolAbril opened this issue Mar 29, 2021 · 4 comments
Labels
tracker id Issues used as trackers in the notebook update project, do not close!

Comments

@OriolAbril
Copy link
Member

File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/case_studies/hierarchical_partial_pooling.ipynb
Reviewers: @OriolAbril

Changes for discussion

Changes listed in this section are up for discussion, these are ideas on how to improve
the notebook but may not have a clear implementation, or fix some know issue only partially.

ArviZ related

  • Consider using new ArviZ labeling capabilities in the plot_forest to avoid having to manually set the yticklabels. We'd instead use coords for that.
    • Note labeller feature in ArviZ has not been released yet, this requires waiting for this.

Notes

Exotic dependencies

None

Computing power

Model runs in roughly a minute

@OriolAbril OriolAbril added the tracker id Issues used as trackers in the notebook update project, do not close! label Mar 29, 2021
@mjhajharia
Copy link
Member

mjhajharia commented Aug 17, 2021

I was working on hierarchical partial pooling last week for a talk proposal!! I'll be happy to take this up, assigning myself if that's okay

@mjhajharia mjhajharia self-assigned this Aug 17, 2021
@OriolAbril
Copy link
Member Author

That would be great. The only change I had in mind however relies on ArviZ>0.11.2 which I think should be released any day now that gsoc is over? cc @canyon289 was also the release manager here

@canyon289
Copy link
Member

canyon289 commented Aug 23, 2021

@mjhajharia Assigning yourself is great. Well probably release arviz before youre done with your talk which is good. It means when you give your talk people will be able to use the notebook immediately

@azihna
Copy link
Contributor

azihna commented Jul 9, 2022

Working on this with @PrinceAsiedu

twiecki pushed a commit that referenced this issue Jan 17, 2023
* add argument parser

* extend argument parser

* prepare a valid fixture

* improve fixture

* improve fixture

* use simplex transform for the test case

* add parse args

* add flatten util

* fix typo

* refactor flattening

* add mean chol

* add test for mvn_prior

* test final api

* add additional argument

* add type hints

* fix tests

* add a docstring

* add to docs

* simplify implementation

* Update pymc_experimental/utils/prior.py

Co-authored-by: Oriol Abril-Pla <[email protected]>

* Update pymc_experimental/utils/prior.py

Co-authored-by: Oriol Abril-Pla <[email protected]>

* update the docstring

* update the docstring

Co-authored-by: Oriol Abril-Pla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracker id Issues used as trackers in the notebook update project, do not close!
Projects
Development

No branches or pull requests

4 participants