-
-
Notifications
You must be signed in to change notification settings - Fork 267
GLM truncated & censored #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I had this example notebook accepted a few months ago - never made it live on the website. I think it just needs some small things done (i.e. from the Notebook updates overview) to follow best practice. Happy for you to assign me to this. |
Just checking the procedure... I should make a pull request when I'm done, and reference this issue? |
Yes, when you open the PR link this issue so it will keep track of all the evolution of the notebook. Once merged I'll triage it to "best practices" and github will add the "oriol moved this issue to best practices in notebook tracker", then someone will make a PR for v4 also linkong here... |
can I take this up? |
This is now done here in a notebook that has been merged https://github.com/pymc-devs/pymc-examples/blob/main/examples/generalized_linear_models/GLM-truncated-censored-regression.ipynb |
Please do not close any I also make sure all PRs link to the right issue, so if everithing goes according to plan and I don't forget anything, the issues themselves will (like this one) show the "xxx mentioned this issue" with the merged icon and label as well as the "xxx added this to Column # in Notebook state tracker", which I think is informative enough for people who want to work on this to see what needs to be done about the issue. |
* added predict_posterior * changed tests * Update pymc_experimental/model_builder.py Co-authored-by: Thomas Wiecki <[email protected]>
File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/generalized_linear_models/GLM-truncated-censored-regression.ipynb
Reviewers:
Known changes needed
Changes listed in this section should all be done at some point in order to get this
notebook to a "Best Practices" state. However, these are probably not enough!
Make sure to thoroughly review the notebook and search for other updates.
General updates
ArviZ related
Changes for discussion
Changes listed in this section are up for discussion, these are ideas on how to improve
the notebook but may not have a clear implementation, or fix some know issue only partially.
General updates
ArviZ related
Notes
Exotic dependencies
Computing requirements
The text was updated successfully, but these errors were encountered: