Skip to content

Update GLM negative binomial #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Conversation

chiral-carbon
Copy link
Collaborator

@chiral-carbon chiral-carbon commented Aug 2, 2021

Addresses issue #84 and aims to:

  • advance it to best practices
  • use bambi instead of pymc3 GLM module

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@chiral-carbon chiral-carbon changed the title Update GLM negative binomial to use bambi Update GLM negative binomial Aug 2, 2021
@review-notebook-app
Copy link

review-notebook-app bot commented Aug 3, 2021

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2021-08-03T19:31:51Z
----------------------------------------------------------------

I actually have not been checking that and leaving this for when we had decided something on https://github.com//issues/198 but it may be worth it to start already. Here you should add that you ported the notebook to bambi.


chiral-carbon commented on 2021-08-04T12:51:45Z
----------------------------------------------------------------

oh yes, overlooked the text here by mistake. will change it.

Copy link
Collaborator Author

oh yes, overlooked the text here by mistake. will change it.


View entire conversation on ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Aug 10, 2021

View / edit / reply to this conversation on ReviewNB

MarcoGorelli commented on 2021-08-10T19:59:50Z
----------------------------------------------------------------

Finally, the mean of nsneeze_alpha is also quite close to its actual value of 10.

Not sure I see how this follows from the above - perhaps add a cell which shows nsneeze_alpha?


MarcoGorelli commented on 2021-08-10T20:12:54Z
----------------------------------------------------------------

sorry, nevermind, it appears in the trace plot above (just not in the summary) - this is fine then :)

Copy link
Contributor

sorry, nevermind, it appears in the trace plot above (just not in the summary) - this is fine then :)


View entire conversation on ReviewNB

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

MarcoGorelli commented on 2021-08-10T20:17:03Z
----------------------------------------------------------------

3*6*2=16 times.

this isn't right (I know you didn't write it 😄 still, would be good to fix it here, and it's a markdown cell so it doesn't require re-running the rest of the notebook)


Copy link
Contributor

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli MarcoGorelli merged commit 5e29ce8 into pymc-devs:main Aug 10, 2021
@chiral-carbon chiral-carbon deleted the neg-binom branch August 27, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants