Spline example #232
Spline example #232
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB canyon289 commented on 2021-10-03T14:20:05Z Line #6. import plotnine as gg The version for this should be added to the watermark to make the plots reproducible jhrcook commented on 2021-10-03T14:34:05Z I believe it already is in the watermark because it is and imported package. In my view of the notebook, 'plotnine' is in the watermark. If you would like me to add it explicitly, though, I can. |
|
I believe it already is in the watermark because it is and imported package. In my view of the notebook, 'plotnine' is in the watermark. If you would like me to add it explicitly, though, I can. View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB canyon289 commented on 2021-10-03T14:34:09Z Line #6. import plotnine as gg Another question, is it possible to use matplotllib instead of plotnine. Ill be the first to say the grammar of graphics syntax is much more intuitive, and matplotlib can get syntax heavy.
From a maintainer perspective though it makes it much easier for us to keep your notebook updated and current, as it means less tools needed in CI to publish, less libraries that can break things, and when we update notebooks theres less things to update in general.
Let me know what you think! Again this notebook looks great really looking forward to merging it! jhrcook commented on 2021-10-03T14:46:57Z I'm sure it is possible to re-make the plots using 'matplotlib', but, unfortunately, I'm not very proficient with 'matlibplot'. Another option, though I know this is a big ask, is to add 'plotnine' to the environment. canyon289 commented on 2021-10-03T15:41:19Z No worries. Let me let another maintainer whos more aware of the docs opine on this. Hoping to help you get this merged |
|
View / edit / reply to this conversation on ReviewNB canyon289 commented on 2021-10-03T14:34:10Z Line #2. blossom_data = pd.read_csv(Path("..", "data", "cherry_blossoms.csv"), sep=";")
This is great. Thank you |
|
View / edit / reply to this conversation on ReviewNB canyon289 commented on 2021-10-03T14:34:11Z Great notebook, thanks for contributing jhrcook commented on 2021-10-03T14:42:26Z Thank you, I'm happy I can contribute to the PyMC3 community. |
|
Thank you, I'm happy I can contribute to the PyMC3 community. View entire conversation on ReviewNB |
|
I'm sure it is possible to re-make the plots using 'matplotlib', but, unfortunately, I'm not very proficient with 'matlibplot'. Another option, though I know this is a big ask, is to add 'plotnine' to the environment. View entire conversation on ReviewNB |
|
No worries. Let me let another maintainer whos more aware of the docs opine on this. Hoping to help you get this merged View entire conversation on ReviewNB |
|
Hey Josh, |
|
You reviewed and merged this within a day, so no need to apologize for a delay. Again, I’m happy I could contribute to PyMC3 given how much it and the community have helped me. If possible, could you add the label |
|
Of course |
|
I added the hacktoberfest topic to the repo which I think was the reason it did not count. From what I understand reading https://hacktoberfest.digitalocean.com/resources/maintainers, PRs only need the hacktoberfest-accepted label if they are not approved nor merged during October. Let us know if things are working now |
Description
Addresses issue #230 and aims to advance it to Best Practices.
This PR is for a contribution of an example of a spline regression in PyMC3.