Skip to content

Use standard bambi import #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

hectormz
Copy link
Contributor

@hectormz hectormz commented May 3, 2022

Use standard bambi import, matching other example notebooks

This PR updates the GLM notebook to use the bambi import style used in the rest of the notebooks:

import bambi as bmb

instead of:

import bambi

This small PR did not have an attached issue...

Helpful links

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -24,7 +24,7 @@
"import os\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #14.    print(f"Running on PyMC3 v{pm.__version__}")

While you are here, could you replace all instances of pymc3 with pymc and ensure that it runs?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fonnesbeck @aloctavodia Is there a version/branch of bambi that is running on/with pymc? I don't see anything on github to try

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not yet, there is a v4 PR open but its not yet working bambinos/bambi#496

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so I won't make the other changes @fonnesbeck mentioned just yet.

@hectormz
Copy link
Contributor Author

My pre-commit wasn't setup for the repo, so I needed to apply black formatting and update the myst notebook

@drbenvincent
Copy link
Contributor

It was decided that this notebook should be removed. See #91, and was killed in #336.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants