Skip to content

update to use pm.Truncated #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2022
Merged

update to use pm.Truncated #423

merged 1 commit into from
Sep 22, 2022

Conversation

drbenvincent
Copy link
Contributor

@drbenvincent drbenvincent commented Sep 22, 2022 •
edited
Loading

Resolves #422
Resolves #399

Now utilising pm.Truncated. Just a few minor changes:

  • Truncated example now uses pm.Truncated
  • Now use current method to get model logp (used in a plot). Changes are simply:
    • from logp_fn = m.logp to logp_fn = m.compile_logp()
  • Added new "updated by" in the Authors section.

@drbenvincent
Copy link
Contributor Author

Hmm @ricardoV94 approved, but still can't merge.

@ricardoV94
Copy link
Member

Hmm @ricardoV94 approved, but still can't merge.

I don't have write permissions in this repo, so my review is just symbolic ;)

@drbenvincent drbenvincent merged commit 1656c38 into pymc-devs:main Sep 22, 2022
@drbenvincent drbenvincent deleted the trunc branch September 22, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junpenglao junpenglao junpenglao approved these changes

@ricardoV94 ricardoV94 ricardoV94 approved these changes

@OriolAbril OriolAbril Awaiting requested review from OriolAbril

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update notebook(s) to use pm.Truncated unhashable type: 'dict' in Bayesian regression with truncated or censored data
3 participants
@drbenvincent @ricardoV94 @junpenglao