Filter warning for batched_dot until we change it #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
requested changes
Apr 12, 2025
ricardoV94
approved these changes
Apr 12, 2025
|
Does a name change not warrant a DeprecationWarning? What else would we use
if we intend to remove `compile_pymc` eventually?
…On Sat, 12 Apr 2025, 16:30 Ricardo Vieira, ***@***.***> wrote:
***@***.**** approved this pull request.
looks good if tests pass. Why are we calling compile_pymc though? That's
just a name change... People seem to be getting the point of deprecation
warning wrong :)
—
Reply to this email directly, view it on GitHub
<#455 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACCUIVMT3SAY4M44V2ECD2ZEPPBAVCNFSM6AAAAAB277PCCCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONRSGE3TGMZUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yes it warrants, but here in extras we should just have updated, not ignored it. That's a silly reaction to the warning |
|
They are updated in #453
…On Sat, 12 Apr 2025, 17:11 Ricardo Vieira, ***@***.***> wrote:
Yes it warrants, but here in extras we should just have updated, not
ignored it. That's a silly reaction to the warning
—
Reply to this email directly, view it on GitHub
<#455 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACCUNUHYXGIUEC76YL3ID2ZEUKJAVCNFSM6AAAAAB277PCCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJYHA3DQNJWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*ricardoV94* left a comment (pymc-devs/pymc-extras#455)
<#455 (comment)>
Yes it warrants, but here in extras we should just have updated, not
ignored it. That's a silly reaction to the warning
—
Reply to this email directly, view it on GitHub
<#455 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACCUNUHYXGIUEC76YL3ID2ZEUKJAVCNFSM6AAAAAB277PCCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJYHA3DQNJWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we figure out how to remove deprecated functionality in #453 this PR should get
mainbuilding properly again!