Skip to content

Blog: PyData London 2022 talk by Chris Fonnesbeck #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 1, 2023

Conversation

BerylKanali
Copy link
Contributor

@OriolAbril
Copy link
Member

@BerylKanali @reshamas not sure if I should review here or in #70

@reshamas
Copy link
Contributor

@BerylKanali @reshamas not sure if I should review here or in #70

@OriolAbril You can review this PR.
I am not sure why (either PR) it's failing the check.

@OriolAbril
Copy link
Member

I am not sure why (either PR) it's failing the check.

It gets stuck installing ablog, I don't understand either. I'll try rerunning and see if something changes.

<br>

## Outline

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all at the same level? If possible I'd organize them in headings and subheadings. I'd also try to combine this section with the timestamps.

I saw the "what to do when things go wrong" and thought let me get to this timestamp, I bet the ~4 following points are a subsection of this. But it doesn't have a timestamp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outline was what was provided before the actual talk so combining it with the talk might be not so ideal, it might be repetitive or not in place. The timestamps are more beneficial since they highlight the exact flow of the talk and I think even if we add them as sections to the timestamps it wont make any difference and maybe make the timestamps less specific.

Alternatively, we can do away with the outline and remain with only the timestamps since they are more important.

Let me know what you think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the outline sounds good then

@OriolAbril
Copy link
Member

I have fixed the build in #73, you'll need to rebase to get the preview working.

@BerylKanali
Copy link
Contributor Author

@OriolAbril
I removed the outline, I think everything is okay now.

@reshamas
Copy link
Contributor

reshamas commented Feb 1, 2023

Thanks @BerylKanali.

@reshamas reshamas merged commit 33aeede into pymc-devs:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants