Skip to content

Issue page for xfails added during aeppl integration. #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 6 tasks
kc611 opened this issue Oct 19, 2021 · 3 comments
Closed
5 of 6 tasks

Issue page for xfails added during aeppl integration. #5088

kc611 opened this issue Oct 19, 2021 · 3 comments

Comments

@kc611
Copy link
Contributor

kc611 commented Oct 19, 2021

The XFails added during aeppl integration #4887 :

  • pymc/tests/test_idata_conversion.py::TestDataPyMC::test_multivariate_observations : Already fixed. Xfail decorator can be removed on next release of Aesara.
  • pymc/tests/test_transforms.py::TestElementWiseLogp::test_beta_ordered : Already fixed. Xfail decorator can be removed on next release of Aesara.
  • pymc/tests/test_sampling.py::TestSamplePPC::test_deterministic_of_observed: Failing on specific systems similar to those above. i.e. Float32 Linux systems. This was caused by the new Assertions introduced by aeppl and discussed in AssertionError in aeppl.logp breaks sampling in pymc aesara-devs/aeppl#84. Unpin aeppl version #5203 Fixes this by making the prior more lenient.
  • pymc/tests/test_posteriors.py::TestSliceUniform : Failing on specific systems similar to those above. i.e. Float32 Linux systems. Fixed in Unpin aeppl version #5203
  • pymc/tests/test_transforms.py::test_interval_near_boundary : This test produces infinite values using aeppl. Fixed in Unpin aeppl version #5203
  • pymc/tests/test_transforms.py::test_chain_jacob_det : Fails due to precision issue. Values just close to expected. (Deviation of order 10^-6).
    • The log_jac_det of the LogOdds transform is slightly different than the previous implementation and less comparable to the one given by actual_ljd function. This difference could be due to either a lower or higher numerical precision of the new log_jac_det, and it is unclear which one it is without access to an evaluation with known error bounds.

We can discuss these over here.

@twiecki
Copy link
Member

twiecki commented Oct 19, 2021

@brandonwillard will cut a new aesara release so that should help with some of these.

@twiecki
Copy link
Member

twiecki commented Oct 20, 2021

@kc611 we have a new aesara release: https://github.com/aesara-devs/aesara/releases/tag/rel-2.2.3 (thanks @brandonwillard !)

@ricardoV94
Copy link
Member

Closing this given given no complaints/ low priority/ need for investigation

@ricardoV94 ricardoV94 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants