Skip to content

Sampling issues due to Aeppl logp assertions #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ricardoV94 opened this issue Nov 18, 2021 · 1 comment · Fixed by #5233
Closed

Sampling issues due to Aeppl logp assertions #5205

ricardoV94 opened this issue Nov 18, 2021 · 1 comment · Fixed by #5233
Assignees
@ricardoV94
Labels
bug logprob
Milestone
v4.0.0b1 (vNext)

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Nov 18, 2021 •
edited
Loading

As discussed in aesara-devs/aeppl#84, Aeppl introduced explicit Aesara asserts in the logp graphs of several distributions. Until a rewrite is implemented there or here, we can expect to see some AssertionErrors crashing pm.sampling.

For instance, one of the test regression documented in #5088 was precisely because of this.
@ricardoV94 ricardoV94 added this to the v4.0.0-beta1 (vNext) milestone Nov 18, 2021
@ricardoV94
Copy link
Member Author

Also a good opportunity to turn the model.check_bounds flag into a compile-time optional rewrite.

@ricardoV94 ricardoV94 self-assigned this Nov 19, 2021
@ricardoV94 ricardoV94 mentioned this issue Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardoV94 ricardoV94

Labels
bug logprob
Projects
None yet
Milestone
v4.0.0b1 (vNext)
Development

Successfully merging a pull request may close this issue.

Add rewrites to replace or remove Aeppl CheckParameterValue Ops ricardoV94/pymc
1 participant
@ricardoV94