Refactor Slice.astep #1371
Merged
Refactor Slice.astep #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonnesbeck
approved these changes
Sep 19, 2016
|
Thanks -- will rebase once #1372 is merged! |
ColCarroll
force-pushed
the
refactor_step
branch
from
40d7ee0 to
b7a2ca8
Compare
ColCarroll
force-pushed
the
refactor_step
branch
from
b7a2ca8 to
35e16d9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the imports, renamed some variables. The only functional difference is changing the loop under
if self.tuneto be more efficient. On my machine, this change lowered the time fortest_stepfrom ~80s to ~55s.