test on windows and mac #4269

MarcoGorelli · 2020-11-28T12:57:25Z

Let's see what happens

Stackoverflow error on Windows 🤔

codecov · 2020-11-28T14:07:25Z

Codecov Report

Merging #4269 (56d43b0) into master (3fa3d1f) will decrease coverage by 0.04%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master    #4269      +/-   ##
==========================================
- Coverage   87.69%   87.64%   -0.05%     
==========================================
  Files          88       88              
  Lines       14355    14362       +7     
==========================================
- Hits        12588    12587       -1     
- Misses       1767     1775       +8

Impacted Files	Coverage Δ
pymc3/memoize.py	`83.33% <83.33%> (-12.83%)`	⬇️
pymc3/distributions/posterior_predictive.py	`89.29% <100.00%> (ø)`
pymc3/sampling.py	`87.65% <100.00%> (+0.07%)`	⬆️
pymc3/distributions/distribution.py	`94.01% <0.00%> (-0.25%)`	⬇️

michaelosthege · 2020-11-29T12:49:33Z

The stack overflow 🐛 of test_sampling.py::TestSamplePriorPredictive::test_density_dist on Windows is real!

(pm3-dev) E:\Source\Repos\pymc3\pymc3\tests>pytest test_sampling.py::TestSamplePriorPredictive::test_density_dist -v
================================================================================================================================================================== test session starts ==================================================================================================================================================================
platform win32 -- Python 3.7.9, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 -- c:\...\envs\pm3-dev\python.exe
cachedir: .pytest_cache
rootdir: E:\Source\Repos\pymc3, configfile: setup.cfg
plugins: cov-2.10.1
collected 1 item

test_sampling.py::TestSamplePriorPredictive::test_density_dist Windows fatal exception: stack overflow

Current thread 0x00004570 (most recent call first):
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 479 in get
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 497 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 884 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 846 in _batch_appends
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 819 in save_list
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 890 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 843 in _batch_appends
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 819 in save_list
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 843 in _batch_appends
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 819 in save_list
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 843 in _batch_appends
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 819 in save_list
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 843 in _batch_appends
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 819 in save_list
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 549 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 885 in _batch_setitems
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 859 in save_dict
  File "c:\...\envs\pm3-dev\lib\site-packages\dill\_dill.py", line 941 in save_module_dict
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 504 in save
  File "c:\...\envs\pm3-dev\lib\pickle.py", line 662 in save_reduce
  ...

michaelosthege · 2020-12-05T11:54:11Z

@MarcoGorelli looks like we both made the same mistake in resolving the merge conflict?

I think I have it right now.. Can push it if you want

MarcoGorelli · 2020-12-05T11:56:23Z

It's OK, done 😄

Let's see what errors mac / windows throw now...

MarcoGorelli · 2020-12-05T13:43:54Z

seems like mac tests pass!

tl:dr: The hashable helper function did not appropiately deal with tuples (and the test case did not actually test the memoization). In the process of prior-predictive sampling a model involving a DensityDist, the _compile_theano_function function was called with arguments (sd__log_, []). The _compile_theano_function has a pm.memo.memoize-decorator, which relies on the pm.memo.hashable for hashing of typically unhashable objects. The "hashable" function incorrectly handled tuples, eventually causing a stackoverflow error on Windows.

Fix the stackoverflow problem

michaelosthege

I just noticed two small glitches, but with them fixed I think we're good to go!

.github/workflows/windows.yml

pymc3/util.py

twiecki · 2020-12-06T14:49:31Z

This is amazing!

MarcoGorelli force-pushed the windows-test branch from 411331c to de938fc Compare November 28, 2020 13:36

MarcoGorelli changed the title ~~test on mac and windows, lint config files~~ test on windows Nov 28, 2020

MarcoGorelli marked this pull request as draft November 28, 2020 14:10

run arviz compat on mac and windows

e2f7764

MarcoGorelli force-pushed the windows-test branch from de938fc to e2f7764 Compare November 28, 2020 15:09

MarcoGorelli added 2 commits November 28, 2020 15:32

windows too

0421216

run test_distributions_random.py too on mac

9170203

rpgoldman mentioned this pull request Nov 29, 2020

Recursion error pickling step functions #4273

Closed

Spaak added this to the 3.10 milestone Dec 2, 2020

Merge remote-tracking branch 'upstream/master' into windows-test

907884d

MarcoGorelli force-pushed the windows-test branch from 99185d7 to 907884d Compare December 5, 2020 11:51

update env file in windows

2872c29

activate correct env

1fc0bc8

MarcoGorelli changed the title ~~test on windows~~ test on windows and mac Dec 5, 2020

michaelosthege added bug macOS macOS related tests winOS windows OS related labels Dec 5, 2020

MarcoGorelli added 2 commits December 5, 2020 13:50

xfail on Windows

f913f75

xfail -> skipif

2be485d

MarcoGorelli marked this pull request as ready for review December 5, 2020 15:07

MarcoGorelli mentioned this pull request Dec 5, 2020

test_beta_binomial fails on Windows #4299

Closed

MarcoGorelli and others added 3 commits December 5, 2020 15:51

xfail

33ac2ec

import sys

73ca256

rename dataset_to_points_dict with DeprecationWarning

7fe150f

michaelosthege and others added 6 commits December 5, 2020 19:55

apply black

2e46eb2

remove unused import

0f21fca

apply black via pre-commit

e94b47e

Merge pull request #7 from michaelosthege/windows-test

432bcda

Fix the stackoverflow problem

rewrite dict as literal, use list comprehension

ccedb61

michaelosthege requested changes Dec 6, 2020

View reviewed changes

.github/workflows/windows.yml Outdated Show resolved Hide resolved

pymc3/util.py Outdated Show resolved Hide resolved

punctuation, naming

56d43b0

michaelosthege approved these changes Dec 6, 2020

View reviewed changes

michaelosthege merged commit de47253 into pymc-devs:master Dec 6, 2020

MarcoGorelli mentioned this pull request Dec 7, 2020

Test Windows during CI #4257

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test on windows and mac #4269

test on windows and mac #4269

MarcoGorelli commented Nov 28, 2020 •

edited

Loading

codecov bot commented Nov 28, 2020 •

edited

Loading

michaelosthege commented Nov 29, 2020 •

edited

Loading

michaelosthege commented Dec 5, 2020

MarcoGorelli commented Dec 5, 2020

MarcoGorelli commented Dec 5, 2020

michaelosthege left a comment

twiecki commented Dec 6, 2020

test on windows and mac #4269

test on windows and mac #4269

Conversation

MarcoGorelli commented Nov 28, 2020 • edited Loading

codecov bot commented Nov 28, 2020 • edited Loading

Codecov Report

michaelosthege commented Nov 29, 2020 • edited Loading

michaelosthege commented Dec 5, 2020

MarcoGorelli commented Dec 5, 2020

MarcoGorelli commented Dec 5, 2020

michaelosthege left a comment

Choose a reason for hiding this comment

twiecki commented Dec 6, 2020

MarcoGorelli commented Nov 28, 2020 •

edited

Loading

codecov bot commented Nov 28, 2020 •

edited

Loading

michaelosthege commented Nov 29, 2020 •

edited

Loading