Skip to content

Fast doc build #4477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 22, 2021
Merged

Fast doc build #4477

merged 8 commits into from
Feb 22, 2021

Conversation

Pyrsos
Copy link
Contributor

@Pyrsos Pyrsos commented Feb 15, 2021

Sorry, made a mess on this with the branches. Here are the latest changes for building the docs fast issue #4435
Again apologies for the mess...

Depending on what your PR does, here are a few things you might want to address in the description:

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would name the file fast_build_docs.sh though, as this one does not deploy them to github pages (and should not)

Copy link
Contributor

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pyrsos , much faster like this!

Have just left one small comment, other than that it looks good to me

@MarcoGorelli
Copy link
Contributor

MarcoGorelli commented Feb 16, 2021

As an aside, maybe there should be another script build_docs.sh which:

  • fetches the latest changes from the main branch in pymc-examples (git submodule update --remote)
  • builds the full docs without deploying them

Even better if they could be Python scripts instead of bash ones, so that any contributor on any OS can easily build the docs with just one script

Anyway, all this could be a separate PR


Last piece of advice here would be to make PRs from new branches rather than from master

Change `sh` -> `bash` in shell script

Co-authored-by: Marco Gorelli <[email protected]>
@Pyrsos
Copy link
Contributor Author

Pyrsos commented Feb 19, 2021

Sorry for the delay @MarcoGorelli, I have now made the suggested changes. I'd be happy to work on a separate PR for your suggestions to change from bash scripts to Python scripts. Should I open an issue for this?

Copy link
Contributor

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!

and yes, I think opening an issue would be good so it doesn't get forgotten

@Pyrsos
Copy link
Contributor Author

Pyrsos commented Feb 21, 2021

OK, I have opened another issue here #4483. Is there anything else I need to do with this one or can it be merged? I do not think I have write access to the repository to do the merge.

@OriolAbril OriolAbril merged commit 6360b00 into pymc-devs:master Feb 22, 2021
@OriolAbril
Copy link
Member

This is all for now, the other tasks have issue remainders and can be done in follow up PRs. Thanks for the PR @Pyrsos !

sthagen added a commit to sthagen/pymc-devs-pymc that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants