-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fast doc build #4477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast doc build #4477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would name the file fast_build_docs.sh
though, as this one does not deploy them to github pages (and should not)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Pyrsos , much faster like this!
Have just left one small comment, other than that it looks good to me
As an aside, maybe there should be another script
Even better if they could be Python scripts instead of bash ones, so that any contributor on any OS can easily build the docs with just one script Anyway, all this could be a separate PR Last piece of advice here would be to make PRs from new branches rather than from master |
Change `sh` -> `bash` in shell script Co-authored-by: Marco Gorelli <[email protected]>
Sorry for the delay @MarcoGorelli, I have now made the suggested changes. I'd be happy to work on a separate PR for your suggestions to change from bash scripts to Python scripts. Should I open an issue for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks!
and yes, I think opening an issue would be good so it doesn't get forgotten
OK, I have opened another issue here #4483. Is there anything else I need to do with this one or can it be merged? I do not think I have write access to the repository to do the merge. |
This is all for now, the other tasks have issue remainders and can be done in follow up PRs. Thanks for the PR @Pyrsos ! |
Fast doc build (pymc-devs#4477)
Sorry, made a mess on this with the branches. Here are the latest changes for building the docs fast issue #4435
Again apologies for the mess...
Depending on what your PR does, here are a few things you might want to address in the description: